Commit 315a40ee authored by David Tseng's avatar David Tseng Committed by Commit Bot

Scope ChromeVox navigation within content editables only when it has content

Bug: 849726
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Ie758887410ce95bd4650e46c31a3d81c9b450930
Reviewed-on: https://chromium-review.googlesource.com/1087499Reviewed-by: default avatarDominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#564915}
parent 1fc1ceaa
...@@ -395,9 +395,10 @@ AutomationPredicate.root = function(node) { ...@@ -395,9 +395,10 @@ AutomationPredicate.root = function(node) {
* @param {AutomationNode} node * @param {AutomationNode} node
* @return {boolean} * @return {boolean}
*/ */
AutomationPredicate.editableRoot = function(node) { AutomationPredicate.rootOrEditableRoot = function(node) {
return AutomationPredicate.root(node) || return AutomationPredicate.root(node) ||
node.state.richlyEditable && node.state.focused; (node.state.richlyEditable && node.state.focused &&
node.children.length > 0);
}; };
/** /**
......
...@@ -250,7 +250,7 @@ CommandHandler.onCommand = function(command) { ...@@ -250,7 +250,7 @@ CommandHandler.onCommand = function(command) {
var dir = Dir.FORWARD; var dir = Dir.FORWARD;
var pred = null; var pred = null;
var predErrorMsg = undefined; var predErrorMsg = undefined;
var rootPred = AutomationPredicate.editableRoot; var rootPred = AutomationPredicate.rootOrEditableRoot;
var shouldWrap = true; var shouldWrap = true;
var speechProps = {}; var speechProps = {};
var skipSync = false; var skipSync = false;
...@@ -756,7 +756,7 @@ CommandHandler.onCommand = function(command) { ...@@ -756,7 +756,7 @@ CommandHandler.onCommand = function(command) {
} }
var root = bound; var root = bound;
while (root && !AutomationPredicate.editableRoot(root)) while (root && !AutomationPredicate.rootOrEditableRoot(root))
root = root.parent; root = root.parent;
if (!root) if (!root)
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment