Commit 315d6ec3 authored by Brian Sheedy's avatar Brian Sheedy Committed by Commit Bot

Remove dump_syms dependency on Windows

There is an issue when building //third_party/breakpad:dump_syms
in cross-compiled builds. Since dump_syms is unused in Telemetry
on Windows anyways, remove the dependency entirely on that platform.

TBR=crouleau@chromium.org

Bug: 1055301
Change-Id: Ic78db0dff8fe6ffe008cd4610393b654775593d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2070200Reviewed-by: default avatarBrian Sheedy <bsheedy@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744085}
parent 8a13e3ff
...@@ -102,13 +102,17 @@ group("telemetry_chrome_test_without_chrome") { ...@@ -102,13 +102,17 @@ group("telemetry_chrome_test_without_chrome") {
"//components/crash/content/tools/generate_breakpad_symbols.py", "//components/crash/content/tools/generate_breakpad_symbols.py",
] ]
data_deps = [ data_deps = [
"//third_party/breakpad:dump_syms",
"//third_party/catapult:telemetry_chrome_test_support", "//third_party/catapult:telemetry_chrome_test_support",
"//tools/metrics:metrics_python_tests", "//tools/metrics:metrics_python_tests",
] ]
if (!is_win) { if (!is_win) {
data_deps += [ data_deps += [
# This is defined for Windows, but is unused by Telemetry on
# Windows, and including it can have issues when cross-compiling
# for Arm-based Windows.
"//third_party/breakpad:dump_syms",
# These explicitly not defined for Windows builds in Breakpad. # These explicitly not defined for Windows builds in Breakpad.
"//third_party/breakpad:minidump_dump", "//third_party/breakpad:minidump_dump",
"//third_party/breakpad:minidump_stackwalk", "//third_party/breakpad:minidump_stackwalk",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment