Commit 317b15f8 authored by Peter Wen's avatar Peter Wen Committed by Commit Bot

Android: Use dots to distinguish java build steps

This CL in conjunction with https://crrev.com/c/2142163 allows us to
better distinguish java build steps.

Example:
Time by build-step type:
  10.1 s weighted time to generate 678 .mojom-shared.o files (5555.1 s elapsed time sum)
  11.9 s weighted time to generate 1 .resource_ids files (11.9 s elapsed time sum)
  13.3 s weighted time to generate 296 .bytecode-rewritten.jar files (407.3 s elapsed time sum)
  15.4 s weighted time to generate 311 .jetified.jar files (505.0 s elapsed time sum)
  17.6 s weighted time to generate 6141 .stamp files (3093.7 s elapsed time sum)
  21.3 s weighted time to generate 244 .javac.jar files (1588.1 s elapsed time sum)
  26.1 s weighted time to generate 160 .lint.stamp files (2545.7 s elapsed time sum)
  29.6 s weighted time to generate 162 .errorprone.stamp files (1592.9 s elapsed time sum)
  62.4 s weighted time to generate 319 .dex.jar files (1794.8 s elapsed time sum)
 146.9 s weighted time to generate 21403 .o files (244220.0 s elapsed time sum)
418.0 s weighted time (291862.9 s elapsed time sum, 698.2x parallelism)

Bug: 1067273
Change-Id: Id0ac5ef63c3b0a9f4849ade5e20c9eb896f93917
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142395Reviewed-by: default avatarAndrew Grieve <agrieve@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Auto-Submit: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#757578}
parent 292fe401
......@@ -866,7 +866,7 @@ if (enable_java_templates) {
_cache_dir = "$root_build_dir/android_lint_cache"
_result_path = "$target_out_dir/$target_name/result.xml"
_config_path = "$target_out_dir/$target_name/config.xml"
_stamp_path = "$target_out_dir/$target_name/build.stamp"
_stamp_path = "$target_out_dir/$target_name/build.lint.stamp"
_suppressions_file = lint_suppressions_file
_platform_xml_path =
"${android_sdk_root}/platform-tools/api/api-versions.xml"
......@@ -1606,7 +1606,7 @@ if (enable_java_templates) {
if (!_skip_jetify) {
_jetify_target = "${target_name}__jetify"
_jetify_input_jar = _previous_output_jar
_jetify_output_jar = "$target_out_dir/$target_name-jetified.jar"
_jetify_output_jar = "$target_out_dir/$target_name.jetified.jar"
action_with_pydeps(_jetify_target) {
script = "//build/android/gyp/jetify_jar.py"
......@@ -1645,7 +1645,7 @@ if (enable_java_templates) {
_java_bytecode_rewriter_target = "${target_name}__bytecode_rewrite"
_java_bytecode_rewriter_input_jar = _previous_output_jar
_java_bytecode_rewriter_output_jar =
"$target_out_dir/$target_name-bytecode-rewritten.jar"
"$target_out_dir/$target_name.bytecode-rewritten.jar"
action_with_pydeps(_java_bytecode_rewriter_target) {
script = "//build/android/gyp/bytecode_processor.py"
......@@ -1699,7 +1699,7 @@ if (enable_java_templates) {
if (invoker.enable_desugar) {
_desugar_target = "${target_name}__desugar"
_desugar_input_jar = _previous_output_jar
_desugar_output_jar = "$target_out_dir/$target_name-desugar.jar"
_desugar_output_jar = "$target_out_dir/$target_name.desugar.jar"
action_with_pydeps(_desugar_target) {
script = "//build/android/gyp/desugar.py"
......@@ -1741,7 +1741,7 @@ if (enable_java_templates) {
if (_filter_jar) {
_filter_target = "${target_name}__filter"
_filter_input_jar = _previous_output_jar
_filter_output_jar = "$target_out_dir/$target_name-filtered.jar"
_filter_output_jar = "$target_out_dir/$target_name.filtered.jar"
action_with_pydeps(_filter_target) {
script = "//build/android/gyp/filter_zip.py"
......@@ -1776,7 +1776,7 @@ if (enable_java_templates) {
# Jacoco must run after desugar (or else desugar sometimes fails).
_jacoco_target = "${target_name}__jacoco"
_jacoco_input_jar = _previous_output_jar
_jacoco_output_jar = "$target_out_dir/$target_name-instrumented.jar"
_jacoco_output_jar = "$target_out_dir/$target_name.instrumented.jar"
jacoco_instr(_jacoco_target) {
deps = _deps
......@@ -3322,7 +3322,7 @@ if (enable_java_templates) {
_accumulated_deps += [ _sdk_java_dep ]
}
_jetified_jar_path =
"$target_out_dir/${target_name}__process_prebuilt-jetified.jar"
"$target_out_dir/${target_name}__process_prebuilt.jetified.jar"
# Define build_config_deps which will be a list of targets required to
# build the _build_config.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment