Ignore password related predictions for non-password fields.

The server might make mistake and say that <input type=text is
password field. This CL teaches the new parser to ignore such
predictions.

Bug: 908869, 831123
Change-Id: Ib4cfa715e0746b828be3c2356e8ae5bc60717a69
Reviewed-on: https://chromium-review.googlesource.com/c/1354000
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#612134}

components/password_manager/core/browser/form_parsing/form_parser.cc

@@ -235,6 +235,8 @@ std::unique_ptr<SignificantFields> ParseUsingPredictions(
           processed_field =
               FindFieldWithUniqueRendererId(processed_fields, prediction.first);
           if (processed_field) {
+            if (!processed_field->is_password)
+              return nullptr;
             result->password = processed_field->field;
           }
         }
@@ -254,6 +256,8 @@ std::unique_ptr<SignificantFields> ParseUsingPredictions(
           processed_field =
               FindFieldWithUniqueRendererId(processed_fields, prediction.first);
           if (processed_field) {
+            if (!processed_field->is_password)
+              return nullptr;
             result->new_password = processed_field->field;
           }
         }
@@ -262,6 +266,8 @@ std::unique_ptr<SignificantFields> ParseUsingPredictions(
         processed_field =
             FindFieldWithUniqueRendererId(processed_fields, prediction.first);
         if (processed_field) {
+          if (!processed_field->is_password)
+            return nullptr;
           result->confirmation_password = processed_field->field;
         }
         break;

components/password_manager/core/browser/form_parsing/form_parser_unittest.cc

@@ -1045,6 +1045,17 @@ TEST(FormParserTest, ServerHints) {
               },
           .number_of_all_possible_passwords = 4,
       },
+      {
+          "password prediction for a non-password field is ignored",
+          {
+              {.role = ElementRole::USERNAME,
+               .prediction = {.type = autofill::PASSWORD},
+               .form_control_type = "text"},
+              {.role = ElementRole::CURRENT_PASSWORD,
+               .form_control_type = "password"},
+          },
+      },
+
   });
 }