Commit 3189784f authored by Mikel Astiz's avatar Mikel Astiz Committed by Commit Bot

[sync] Remove a few TODOs

After careful consideration, there is no obvious solution to revert back
to SyncApiComponentFactory without a big amount of refactoring that
doesn't seem justified because of this small TODO.

Change-Id: I3e1d6fbe473c07b492fbdb2ce4e15ec3706aa53e
Fixed: 915154
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480084
Auto-Submit: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#818388}
parent 24524036
......@@ -89,8 +89,6 @@ class ChromeSyncClient : public browser_sync::BrowserSyncClient {
Profile* const profile_;
// The sync api component factory in use by this client.
// TODO(crbug.com/915154): Revert to SyncApiComponentFactory once common
// controller creation is moved elsewhere.
std::unique_ptr<browser_sync::ProfileSyncComponentsFactoryImpl>
component_factory_;
......
......@@ -62,8 +62,6 @@ class IOSChromeSyncClient : public browser_sync::BrowserSyncClient {
ChromeBrowserState* const browser_state_;
// The sync api component factory in use by this client.
// TODO(crbug.com/915154): Revert to SyncApiComponentFactory once common
// controller creation is moved elsewhere.
std::unique_ptr<browser_sync::ProfileSyncComponentsFactoryImpl>
component_factory_;
......
......@@ -74,8 +74,6 @@ class WebViewSyncClient : public browser_sync::BrowserSyncClient {
invalidation::InvalidationService* invalidation_service_;
syncer::SyncInvalidationsService* sync_invalidations_service_;
// TODO(crbug.com/915154): Revert to SyncApiComponentFactory once common
// controller creation is moved elsewhere.
std::unique_ptr<browser_sync::ProfileSyncComponentsFactoryImpl>
component_factory_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment