Commit 31983531 authored by cmumford's avatar cmumford Committed by Commit bot

IndexedDB: Enable leveldb log reuse on Chrome OS.

Reuse was disabled in #317499 because CrOS corruption rates were spiking and
were too close to the stable branch point to gather more history.  Re-enabling
to allow monitoring in dev/beta channels with the hope that the rise we saw on
CrOS was normal fluctuations and unrelated to this change.

BUG=460568

Review URL: https://codereview.chromium.org/1023773003

Cr-Commit-Position: refs/heads/master@{#321427}
parent dbfa9102
...@@ -103,12 +103,7 @@ static leveldb::Status OpenDB( ...@@ -103,12 +103,7 @@ static leveldb::Status OpenDB(
options.create_if_missing = true; options.create_if_missing = true;
options.paranoid_checks = true; options.paranoid_checks = true;
options.filter_policy = filter_policy->get(); options.filter_policy = filter_policy->get();
#if defined(OS_CHROMEOS)
// Disabled on CrOS until crbug.com/460568 is fixed.
options.reuse_logs = false;
#else
options.reuse_logs = true; options.reuse_logs = true;
#endif
options.compression = leveldb::kSnappyCompression; options.compression = leveldb::kSnappyCompression;
// For info about the troubles we've run into with this parameter, see: // For info about the troubles we've run into with this parameter, see:
......
...@@ -896,14 +896,6 @@ Status ChromiumEnv::NewWritableFile(const std::string& fname, ...@@ -896,14 +896,6 @@ Status ChromiumEnv::NewWritableFile(const std::string& fname,
Status ChromiumEnv::NewAppendableFile(const std::string& fname, Status ChromiumEnv::NewAppendableFile(const std::string& fname,
leveldb::WritableFile** result) { leveldb::WritableFile** result) {
#if defined(OS_CHROMEOS)
// Disabled until crbug.com/460568 is fixed. Technically this method shouldn't
// be called if reuse_logs is false, but a leveldb bug (fixed, but not yet in
// Chrome) still calls this function. Using default leveldb Env implementation
// to workaround this bug.
return Env::NewAppendableFile(fname, result);
#endif
*result = NULL; *result = NULL;
FilePath path = FilePath::FromUTF8Unsafe(fname); FilePath path = FilePath::FromUTF8Unsafe(fname);
scoped_ptr<base::File> f(new base::File( scoped_ptr<base::File> f(new base::File(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment