Devtools: Keyboard Nav fix for Profiler Panels
This change scopes down a keydown listener in Profiler panels (Memory and Javascript Profiler tools) so that it only applies to the sidebar tree element that the handler manipulates (selecting which profile to view). Previously, any up/down arrow press that was not handled in the entire panel could result in the change in view. For example, with focus on the toolbar dropdown, pressing the down arrow would change the perspective as desired, but pressing up would move back to the start screen by changing the element selected (shown in the before gif below). Now the arrows navigate to the different snapshots/etc only when the sidebar has focus. Before: https://imgur.com/cWO43Tp After: https://imgur.com/03gReuM Bug: 963183 Change-Id: Ie2337449c064b8e3d690dc2cb0ef07be296c798e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1775055Reviewed-by:Erik Luo <luoe@chromium.org> Commit-Queue: Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#695222}
Showing
Please register or sign in to comment