Commit 31c7c401 authored by Hitoshi Yoshida's avatar Hitoshi Yoshida Committed by Commit Bot

Bindings: Fix template parameter in NativeValueTraits<UnionBase>

UnionBase is passed by value, so NativeValueTraits should handle it
not as a pointer.


Bug: 839389
Change-Id: I0a6ca6892bb8ec041376907bf3e5ccd92b797f49
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015867Reviewed-by: default avatarYuki Shiino <yukishiino@chromium.org>
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#734354}
parent af3d4d92
......@@ -795,7 +795,7 @@ template <typename T>
struct NativeValueTraits<
T,
typename std::enable_if_t<std::is_base_of<bindings::UnionBase, T>::value>>
: public NativeValueTraitsBase<T*> {
: public NativeValueTraitsBase<T> {
static T NativeValue(v8::Isolate* isolate,
v8::Local<v8::Value> value,
ExceptionState& exception_state) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment