DevTools: Fix regression that slows down "Goto Source" dialog

The regression was caused by r174810. The root cause is the
implementation of WebInspector.StaticViewportElement which doesn't
support lazy DOM element creation. So every time the viewport processed
cumulative heights of inner elements, it actually forced all DOM elements
for viewport to be created.

To keep things simple, the patch moves fastHeight calls out of
ViewportElement interface into ViewportProvider.

BUG=377749
R=loislo@chromium.org

Review URL: https://codereview.chromium.org/305813005

git-svn-id: svn://svn.chromium.org/blink/trunk@175059 bbb929c8-8fbe-4397-9dbb-9b2b20218538

third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

@@ -159,6 +159,15 @@ WebInspector.ConsoleView.prototype = {
         return this._visibleViewMessages[index];
     },
 
+    /**
+     * @param {number} index
+     * @return {number}
+     */
+    fastHeight: function(index)
+    {
+        return this._visibleViewMessages[index].fastHeight();
+    },
+
     /**
      * @param {!WebInspector.Target} target
      */

third_party/WebKit/Source/devtools/front_end/sources/FilteredItemSelectionDialog.js

@@ -352,6 +352,20 @@ WebInspector.FilteredItemSelectionDialog.prototype = {
         return this._filteredItems.length;
     },
 
+    /**
+     * @param {number} index
+     * @return {number}
+     */
+    fastHeight: function(index)
+    {
+        if (!this._rowHeight) {
+            var delegateIndex = this._filteredItems[index];
+            var element = this._createItemElement(delegateIndex);
+            this._rowHeight = element.measurePreferredSize(this._viewportControl.contentElement()).height;
+        }
+        return this._rowHeight;
+    },
+
     /**
      * @param {number} index
      * @return {!WebInspector.ViewportElement}
@@ -360,11 +374,9 @@ WebInspector.FilteredItemSelectionDialog.prototype = {
     {
         var delegateIndex = this._filteredItems[index];
         var element = this._createItemElement(delegateIndex);
-        if (!this._rowHeight)
-            this._rowHeight = element.measurePreferredSize(this._viewportControl.contentElement()).height;
         if (index === this._selectedIndexInFiltered)
             element.classList.add("selected");
-        return new WebInspector.StaticViewportElement(element, this._rowHeight);
+        return new WebInspector.StaticViewportElement(element);
     },
 
     __proto__: WebInspector.DialogDelegate.prototype

third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js

@@ -65,6 +65,12 @@ WebInspector.ViewportControl.Provider = function()
 }
 
 WebInspector.ViewportControl.Provider.prototype = {
+    /**
+     * @param {number} index
+     * @return {number}
+     */
+    fastHeight: function(index) { return 0; },
+
     /**
      * @return {number}
      */
@@ -86,11 +92,6 @@ WebInspector.ViewportElement.prototype = {
 
     wasShown: function() { },
 
-    /**
-     * @return {number}
-     */
-    fastHeight: function() { },
-
     /**
      * @return {!Element}
      */
@@ -101,12 +102,10 @@ WebInspector.ViewportElement.prototype = {
  * @constructor
  * @implements {WebInspector.ViewportElement}
  * @param {!Element} element
- * @param {number} height
  */
-WebInspector.StaticViewportElement = function(element, height)
+WebInspector.StaticViewportElement = function(element)
 {
     this._element = element;
-    this._height = height;
 }
 
 WebInspector.StaticViewportElement.prototype = {
@@ -114,14 +113,6 @@ WebInspector.StaticViewportElement.prototype = {
 
     wasShown: function() { },
 
-    /**
-     * @return {number}
-     */
-    fastHeight: function()
-    {
-        return this._height;
-    },
-
     /**
      * @return {!Element}
      */
@@ -188,9 +179,9 @@ WebInspector.ViewportControl.prototype = {
         if (!itemCount)
             return;
         this._cumulativeHeights = new Int32Array(itemCount);
-        this._cumulativeHeights[0] = this._provider.itemElement(0).fastHeight();
+        this._cumulativeHeights[0] = this._provider.fastHeight(0);
         for (var i = 1; i < itemCount; ++i)
-            this._cumulativeHeights[i] = this._cumulativeHeights[i - 1] + this._provider.itemElement(i).fastHeight();
+            this._cumulativeHeights[i] = this._cumulativeHeights[i - 1] + this._provider.fastHeight(i);
     },
 
     /**
@@ -361,7 +352,7 @@ WebInspector.ViewportControl.prototype = {
         for (var i = 0; i < this._renderedItems.length; ++i) {
             this._renderedItems[i].willHide();
             // Tolerate 1-pixel error due to double-to-integer rounding errors.
-            if (this._cumulativeHeights && Math.abs(this._cachedItemHeight(this._firstVisibleIndex + i) - this._renderedItems[i].fastHeight()) > 1)
+            if (this._cumulativeHeights && Math.abs(this._cachedItemHeight(this._firstVisibleIndex + i) - this._provider.fastHeight(i + this._firstVisibleIndex)) > 1)
                 delete this._cumulativeHeights;
         }
         this._rebuildCumulativeHeightsIfNeeded();