Commit 31d8df28 authored by Ned Nguyen's avatar Ned Nguyen Committed by Commit Bot

Implement generate_test_also_run_disabled_tests_args for Telemetry unittest script

Bug: 893618
Change-Id: I56f6c0ccf0c7cecfa419d557ed9fc444f500cd2d
Reviewed-on: https://chromium-review.googlesource.com/c/1287039Reviewed-by: default avatarCaleb Rouleau <crouleau@chromium.org>
Reviewed-by: default avatarKenneth Russell <kbr@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#600633}
parent 76e77ff0
...@@ -281,8 +281,7 @@ class BaseIsolatedScriptArgsAdapter(object): ...@@ -281,8 +281,7 @@ class BaseIsolatedScriptArgsAdapter(object):
del retry_limit # unused del retry_limit # unused
raise RuntimeError('this method is not yet implemented') raise RuntimeError('this method is not yet implemented')
def generate_test_also_run_disabled_tests_args(self, also_run_disabled_tests): def generate_test_also_run_disabled_tests_args(self):
del also_run_disabled_tests # unused
raise RuntimeError('this method is not yet implemented') raise RuntimeError('this method is not yet implemented')
def generate_sharding_args(self, total_shard, shard_index): def generate_sharding_args(self, total_shard, shard_index):
...@@ -312,8 +311,7 @@ class BaseIsolatedScriptArgsAdapter(object): ...@@ -312,8 +311,7 @@ class BaseIsolatedScriptArgsAdapter(object):
# Augment test also run disable tests args if needed # Augment test also run disable tests args if needed
if self.options.isolated_script_test_also_run_disabled_tests: if self.options.isolated_script_test_also_run_disabled_tests:
isolated_script_cmd += self.generate_test_also_run_disabled_tests_args( isolated_script_cmd += self.generate_test_also_run_disabled_tests_args()
self.options.isolated_script_test_also_run_disabled_tests)
# Augment shard args if needed # Augment shard args if needed
env = os.environ.copy() env = os.environ.copy()
......
...@@ -41,6 +41,9 @@ class TelemetryUnittestAdapter(common.BaseIsolatedScriptArgsAdapter): ...@@ -41,6 +41,9 @@ class TelemetryUnittestAdapter(common.BaseIsolatedScriptArgsAdapter):
def generate_test_output_args(self, output): def generate_test_output_args(self, output):
return ['--write-full-results-to', output] return ['--write-full-results-to', output]
def generate_test_also_run_disabled_tests_args(self):
return ['--also-run-disabled-tests']
def generate_test_filter_args(self, test_filter_str): def generate_test_filter_args(self, test_filter_str):
return ['--test-filter', test_filter_str] return ['--test-filter', test_filter_str]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment