Commit 31d92458 authored by Andrew Grieve's avatar Andrew Grieve Committed by Commit Bot

apk_operations.py: Fix command-line setting for non-rooted devices

Change-Id: I969673d9b2806d0215b30a425539ce1b15ee3618
Reviewed-on: https://chromium-review.googlesource.com/803948Reviewed-by: default avatarYaron Friedman <yfriedman@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#521745}
parent 9cff69a8
...@@ -108,9 +108,9 @@ def _LaunchUrl(devices, package_name, argv=None, command_line_flags_file=None, ...@@ -108,9 +108,9 @@ def _LaunchUrl(devices, package_name, argv=None, command_line_flags_file=None,
debug_process_name = _NormalizeProcessName(debug_process_name, package_name) debug_process_name = _NormalizeProcessName(debug_process_name, package_name)
def launch(device): def launch(device):
# Set debug app in order to enable reading command line flags on user # --persistent is required to have Settings.Global.DEBUG_APP be set, which
# builds. # we currently use to allow reading of flags. https://crbug.com/784947
cmd = ['am', 'set-debug-app', debug_process_name] cmd = ['am', 'set-debug-app', '--persistent', debug_process_name]
if wait_for_java_debugger: if wait_for_java_debugger:
cmd[-1:-1] = ['-w'] cmd[-1:-1] = ['-w']
# Ignore error since it will fail if apk is not debuggable. # Ignore error since it will fail if apk is not debuggable.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment