Commit 31ef5b44 authored by Dominick Ng's avatar Dominick Ng Committed by Commit Bot

Record navigations in extension-based apps to history.

This CL addresses a bug where bookmark apps (including desktop PWAs) do
not have their navigations record to Chrome history.

Chrome Packaged apps do not have a |browser| object, so removing the is_app()
check will not affect them.

BUG=821685

Change-Id: I87356b6c6d3dad5e4cc321966bf385975adac995
Reviewed-on: https://chromium-review.googlesource.com/c/1388045Reviewed-by: default avatarBen Wells <benwells@chromium.org>
Reviewed-by: default avatarSylvain Defresne <sdefresne@chromium.org>
Reviewed-by: default avatarChristian Dullweber <dullweber@chromium.org>
Commit-Queue: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619581}
parent d684b524
......@@ -177,7 +177,7 @@ void HistoryTabHelper::DidFinishNavigation(
#else
// Don't update history if this web contents isn't associated with a tab.
Browser* browser = chrome::FindBrowserWithWebContents(web_contents());
if (!browser || browser->is_app())
if (!browser)
return;
#endif
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment