Commit 31f5acc5 authored by Juanmi Huertas's avatar Juanmi Huertas Committed by Commit Bot

Fixing issue with ChromeOS test and reenabling the test

There was a missing part of an if cause allowing passthrough to be tried
as a Canvas Resource Provider.
Re adding that check, and removing the expectation of the test to fail.

This CL fixes as well https://buganizer.corp.google.com/issues/158138519

Bug: 1088023
Change-Id: Ic896d0d0b6cdbc72a0751daf0b2e629a0febdf18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230764Reviewed-by: default avatarFernando Serboncini <fserb@chromium.org>
Reviewed-by: default avatarBrian Sheedy <bsheedy@chromium.org>
Commit-Queue: Juanmi Huertas <juanmihd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#775226}
parent 5b88ca04
...@@ -331,6 +331,3 @@ crbug.com/1086687 [ chromeos chromeos-board-kevin ] Pixel_PrecisionRoundedCorner ...@@ -331,6 +331,3 @@ crbug.com/1086687 [ chromeos chromeos-board-kevin ] Pixel_PrecisionRoundedCorner
# Produces blank images on gpu-fyi-try-chromeos-kevin, gpu-fyi-try-chromeos-amd64-generic. # Produces blank images on gpu-fyi-try-chromeos-kevin, gpu-fyi-try-chromeos-amd64-generic.
crbug.com/1086690 [ chromeos ] Pixel_WebGLSadCanvas [ Skip ] crbug.com/1086690 [ chromeos ] Pixel_WebGLSadCanvas [ Skip ]
# Started producing black instead of green on kevin devices
crbug.com/1088023 [ chromeos chromeos-board-kevin ] Pixel_CanvasLowLatencyWebGL [ Failure ]
...@@ -122,7 +122,10 @@ void CanvasRenderingContextHost::CreateCanvasResourceProvider3D( ...@@ -122,7 +122,10 @@ void CanvasRenderingContextHost::CreateCanvasResourceProvider3D(
// If LowLatency is enabled, we need a resource that is able to perform well // If LowLatency is enabled, we need a resource that is able to perform well
// in such mode. It will first try a PassThrough provider and, if that is // in such mode. It will first try a PassThrough provider and, if that is
// not possible, it will try a SharedImage with the appropriate flags. // not possible, it will try a SharedImage with the appropriate flags.
if (RenderingContext() && RenderingContext()->UsingSwapChain()) { if ((RenderingContext() && RenderingContext()->UsingSwapChain()) ||
RuntimeEnabledFeatures::WebGLImageChromiumEnabled()) {
// If either SwapChain is enabled or WebGLImage mode is enabled, we can
// try a passthrough provider.
DCHECK(LowLatencyEnabled()); DCHECK(LowLatencyEnabled());
provider = CanvasResourceProvider::CreatePassThroughProvider( provider = CanvasResourceProvider::CreatePassThroughProvider(
Size(), SharedGpuContext::ContextProviderWrapper(), FilterQuality(), Size(), SharedGpuContext::ContextProviderWrapper(), FilterQuality(),
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment