Commit 3200c62e authored by Karan Bhatia's avatar Karan Bhatia Committed by Commit Bot

DNR: Remove failing DCHECK in ActionTracker destructor.

This CL removes a failing DCHECK in ActionTracker destructor. The DCHECK
probably fails because it seems we might not receive tab close
notifications on shutdown.

BUG=1055034

Change-Id: Ic597adb39fa37038e4349741e66eae62341cc0bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076520
Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org>
Commit-Queue: Karan Bhatia <karandeepb@chromium.org>
Auto-Submit: Karan Bhatia <karandeepb@chromium.org>
Reviewed-by: default avatarKelvin Jiang <kelvinjiang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#744834}
parent 1d0e9e15
...@@ -80,13 +80,6 @@ ActionTracker::ActionTracker(content::BrowserContext* browser_context) ...@@ -80,13 +80,6 @@ ActionTracker::ActionTracker(content::BrowserContext* browser_context)
} }
ActionTracker::~ActionTracker() { ActionTracker::~ActionTracker() {
// Sanity check that only rules corresponding to the unknown tab ID remain.
DCHECK(std::all_of(
rules_tracked_.begin(), rules_tracked_.end(),
[](const std::pair<const ExtensionTabIdKey, TrackedInfo>& key_value) {
return key_value.first.secondary_id == extension_misc::kUnknownTabId;
}));
DCHECK(pending_navigation_actions_.empty()); DCHECK(pending_navigation_actions_.empty());
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment