Renaming unit_test class StubLocalFrameClient to not collide.

ElementVisibilityObserverTest, HTMLMediaElementEventListenersTest and
VideoPainterTest all use a local StubLocalFrameClient class for
testing. That is normally no big deal but in jumbo builds they
can be compiled in the same translation unit and then the classes
will collide. This patch gives the classes unique prefixes.

R=fs@opera.com

Change-Id: I47c7088486456e22ca776419a836f4e5d18be39c
Reviewed-on: https://chromium-review.googlesource.com/574605Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#487122}

third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp

@@ -21,7 +21,7 @@ namespace {
 // alow callers to set the parent/top frames by calling |setParent|. It is used
 // in ElementVisibilityObserverTest in order to mock a RemoteFrame parent of a
 // LocalFrame.
-class StubLocalFrameClient final : public EmptyLocalFrameClient {
+class DOMStubLocalFrameClient final : public EmptyLocalFrameClient {
  public:
   Frame* Parent() const override { return parent_; }
   Frame* Top() const override { return parent_; }
@@ -40,7 +40,7 @@ class StubLocalFrameClient final : public EmptyLocalFrameClient {
 class ElementVisibilityObserverTest : public ::testing::Test {
  protected:
   void SetUp() override {
-    local_frame_client_ = new StubLocalFrameClient();
+    local_frame_client_ = new DOMStubLocalFrameClient();
     dummy_page_holder_ = DummyPageHolder::Create(IntSize(), nullptr,
                                                  local_frame_client_, nullptr);
   }
@@ -51,11 +51,13 @@ class ElementVisibilityObserverTest : public ::testing::Test {
 
   Document& GetDocument() { return dummy_page_holder_->GetDocument(); }
   Page& GetPage() { return dummy_page_holder_->GetPage(); }
-  StubLocalFrameClient* LocalFrameClient() const { return local_frame_client_; }
+  DOMStubLocalFrameClient* LocalFrameClient() const {
+    return local_frame_client_;
+  }
 
  private:
   std::unique_ptr<DummyPageHolder> dummy_page_holder_;
-  Persistent<StubLocalFrameClient> local_frame_client_;
+  Persistent<DOMStubLocalFrameClient> local_frame_client_;
 };
 
 TEST_F(ElementVisibilityObserverTest, ObserveElementWithoutDocumentFrame) {

third_party/WebKit/Source/core/html/HTMLMediaElementEventListenersTest.cpp

@@ -26,9 +26,11 @@ class MockWebMediaPlayer final : public EmptyWebMediaPlayer {
   MOCK_METHOD1(SetIsEffectivelyFullscreen, void(bool));
 };
 
-class StubLocalFrameClient : public EmptyLocalFrameClient {
+class MediaStubLocalFrameClient : public EmptyLocalFrameClient {
  public:
-  static StubLocalFrameClient* Create() { return new StubLocalFrameClient; }
+  static MediaStubLocalFrameClient* Create() {
+    return new MediaStubLocalFrameClient;
+  }
 
   std::unique_ptr<WebMediaPlayer> CreateWebMediaPlayer(
       HTMLMediaElement&,
@@ -47,7 +49,7 @@ class HTMLMediaElementEventListenersTest : public ::testing::Test {
  protected:
   void SetUp() override {
     page_holder_ = DummyPageHolder::Create(IntSize(800, 600), nullptr,
-                                           StubLocalFrameClient::Create());
+                                           MediaStubLocalFrameClient::Create());
   }
 
   Document& GetDocument() { return page_holder_->GetDocument(); }

third_party/WebKit/Source/core/paint/VideoPainterTest.cpp

@@ -49,7 +49,7 @@ class StubWebMediaPlayer : public EmptyWebMediaPlayer {
   ReadyState ready_state_ = kReadyStateHaveNothing;
 };
 
-class StubLocalFrameClient : public EmptyLocalFrameClient {
+class VideoStubLocalFrameClient : public EmptyLocalFrameClient {
  public:
   // LocalFrameClient
   std::unique_ptr<WebMediaPlayer> CreateWebMediaPlayer(
@@ -68,7 +68,7 @@ class VideoPainterTestForSPv2 : public ::testing::Test,
  protected:
   void SetUp() override {
     chrome_client_ = new StubChromeClientForSPv2();
-    local_frame_client_ = new StubLocalFrameClient;
+    local_frame_client_ = new VideoStubLocalFrameClient;
     Page::PageClients clients;
     FillWithEmptyClients(clients);
     clients.chrome_client = chrome_client_.Get();
@@ -89,7 +89,7 @@ class VideoPainterTestForSPv2 : public ::testing::Test,
 
  private:
   Persistent<StubChromeClientForSPv2> chrome_client_;
-  Persistent<StubLocalFrameClient> local_frame_client_;
+  Persistent<VideoStubLocalFrameClient> local_frame_client_;
   std::unique_ptr<DummyPageHolder> page_holder_;
 };