Commit 32281535 authored by Ilia Samsonov's avatar Ilia Samsonov Committed by Commit Bot

Save disabled test results.

If disabled tests run, test launcher was flagged to run them explicitly.
Since we will remove the MANUAL_ flag, we should track the results.

Instead of testing test result tracker procedurally,
We use test launcher unit tests for functional testing.

Bug: 936248
Change-Id: Iafb2d40a9c650964097cd3f1136d6a5012afda3a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1641805
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarDaniel Cheng <dcheng@chromium.org>
Reviewed-by: default avatarErik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#666438}
parent d11bc86e
......@@ -2691,7 +2691,6 @@ test("base_unittests") {
"task_runner_util_unittest.cc",
"template_util_unittest.cc",
"test/launcher/test_launcher_unittest.cc",
"test/launcher/test_results_tracker_unittest.cc",
"test/launcher/unit_test_launcher_unittest.cc",
"test/metrics/histogram_enum_reader_unittest.cc",
"test/metrics/histogram_tester_unittest.cc",
......@@ -2889,7 +2888,6 @@ test("base_unittests") {
"sync_socket_unittest.cc",
"synchronization/waitable_event_watcher_unittest.cc",
"test/launcher/test_launcher_unittest.cc",
"test/launcher/test_results_tracker_unittest.cc",
"test/launcher/unit_test_launcher_unittest.cc",
]
......
......@@ -276,10 +276,6 @@ void TestResultsTracker::GeneratePlaceholderIteration() {
for (auto& full_test_name : test_placeholders_) {
std::string test_name = TestNameWithoutDisabledPrefix(full_test_name);
// Ignore disabled tests.
if (disabled_tests_.find(test_name) != disabled_tests_.end())
continue;
TestResult test_result;
test_result.full_name = test_name;
test_result.status = TestResult::TEST_NOT_RUN;
......
This diff is collapsed.
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment