Commit 325ba678 authored by Tommy Li's avatar Tommy Li Committed by Commit Bot

[omnibox] Relocate On-Focus config in fieldtrial_testing_config.json

Currently, the on-focus configuration in fieldtrial_testing_config.json
is in the "NTPZeroPrefixSuggestions" trial.

The problem is that about_flags.cc configures on-focus suggestions with
the "OmniboxBundledExperimentV1" field trial. This mismatch between
fieldtrial_testing_config.json and about_flags.cc causes a crash.

It's most proper to match what's in fieldtrial_testing_config.json
and about_flags.cc.

We won't be able to match the server-side config all the time, since
Dev/Canary uses the "unbundled" experiment format, and Beta and Stable
use the "bundled" experiment format.

But so long as fieldtrial_testing_config.json and about_flags.cc match,
the client-side code is correct.

Bug: 1015174
Change-Id: I93fd6cf6392f3de2a0e326bbdfe736bb9a10acc2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019329Reviewed-by: default avatarMoe Ahmadi <mahmadi@chromium.org>
Reviewed-by: default avatarBrian White <bcwhite@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#736116}
parent 36c75391
...@@ -3761,15 +3761,9 @@ ...@@ -3761,15 +3761,9 @@
"experiments": [ "experiments": [
{ {
"name": "Enabled", "name": "Enabled",
"params": {
"ZeroSuggestVariant:15:*": "RemoteNoUrl,Local",
"ZeroSuggestVariant:1:*": "RemoteNoUrl,Local",
"ZeroSuggestVariant:7:*": "RemoteNoUrl,Local"
},
"enable_features": [ "enable_features": [
"NtpRealbox", "NtpRealbox",
"NtpRealboxMatchOmniboxTheme", "NtpRealboxMatchOmniboxTheme",
"OmniboxOnFocusSuggestions",
"OmniboxSuggestionTransparencyOptions" "OmniboxSuggestionTransparencyOptions"
] ]
} }
...@@ -4155,7 +4149,10 @@ ...@@ -4155,7 +4149,10 @@
"name": "DesktopExperiments", "name": "DesktopExperiments",
"params": { "params": {
"OmniboxMaxURLMatches": "7", "OmniboxMaxURLMatches": "7",
"UIMaxAutocompleteMatches": "8" "UIMaxAutocompleteMatches": "8",
"ZeroSuggestVariant:15:*": "RemoteNoUrl,Local",
"ZeroSuggestVariant:1:*": "RemoteNoUrl,Local",
"ZeroSuggestVariant:7:*": "RemoteNoUrl,Local"
}, },
"enable_features": [ "enable_features": [
"OmniboxDisplayTitleForCurrentUrl", "OmniboxDisplayTitleForCurrentUrl",
...@@ -4163,6 +4160,7 @@ ...@@ -4163,6 +4160,7 @@
"OmniboxEnableClipboardProviderTextSuggestions", "OmniboxEnableClipboardProviderTextSuggestions",
"OmniboxLocalEntitySuggestions", "OmniboxLocalEntitySuggestions",
"OmniboxMaxURLMatches", "OmniboxMaxURLMatches",
"OmniboxOnFocusSuggestions",
"OmniboxRemoveSuggestionsFromClipboard", "OmniboxRemoveSuggestionsFromClipboard",
"OmniboxRichEntitySuggestions", "OmniboxRichEntitySuggestions",
"OmniboxUIExperimentMaxAutocompleteMatches", "OmniboxUIExperimentMaxAutocompleteMatches",
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment