GitLab

Re-enable site isolation field trial vs manual override tests

This CL re-enables six previously disabled tests for how
password-triggered isolation and strict origin isolation interact with
field trials, memory thresholds, and manual overrides.  These include
*PasswordSiteIsolationFieldTrialTest* and
*StrictOriginIsolationFieldTrialTest*.

These tests were previously disabled due to runtime usage of
ScopedFeatureList (see https://crbug.com/846380).  This is a problem
for browser tests, but less so for unit tests, where such usage is
still allowed.  This CL converts these tests to unit tests in
site_isolation_policy_unittest.cc.  This makes more sense anyway, as
the tests purely check the state of site isolation policy in different
configurations, without relying on any browsertest support.  An added
bonus is that they now also run on Android try bots, whereas
previously there was no Android coverage (browser_tests don't run on
Android).  For that same reason, this CL also converts and moves the
SitePerProcessMemoryThresholdBrowserTest* tests.  This uncovered four
bugs in the tests when run on Android bots, also fixed in this CL.

Bug: 1009828
Change-Id: I10218fcac47284f84d102f6bf3ec1ae3893f3ed3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116150Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#753082}