Commit 327d30fb authored by gavinp@chromium.org's avatar gavinp@chromium.org

Fix uninitialized read in the SimpleCache tests.

DiskCacheEntryTest.SimpleCacheOptimisticWriteReleases did not initialize
its buffer. It was immaterial to the test, but less so to valgrind.

R=zhaoqin@chromium.org
BUG=245952

Review URL: https://chromiumcodereview.appspot.com/16306003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@203887 0039d316-1c4b-4281-b951-d872f2087c98
parent 4a5fe3e2
......@@ -2853,6 +2853,7 @@ TEST_F(DiskCacheEntryTest, SimpleCacheOptimisticWriteReleases) {
const int kWriteSize = 512;
scoped_refptr<net::IOBuffer> buffer1(new net::IOBuffer(kWriteSize));
EXPECT_TRUE(buffer1->HasOneRef());
CacheTestFillBuffer(buffer1->data(), kWriteSize, false);
// An optimistic write happens only when there is an empty queue of pending
// operations. To ensure the queue is empty, we issue a write and wait until
......
......@@ -7352,21 +7352,6 @@ fun:_ZN7content21RenderViewHostManager8NavigateERKNS_19NavigationEntryImplE
fun:_ZN7content21ContentMainRunnerImpl3RunEv
fun:_ZN7content11ContentMainEiPPKcPNS_19ContentMainDelegateE
}
{
bug_245952a
Memcheck:Uninitialized
fun:crc32_little
fun:MOZ_Z_crc32
fun:_ZN10disk_cache15SimpleEntryImpl17WriteDataInternalEiiPN3net8IOBufferEiRKN4base8CallbackIFviEEEb
}
{
bug_245952b
Memcheck:Param
pwrite64(buf)
obj:/lib/x86_64-linux-gnu/libpthread-2.15.so
fun:_ZN4base17WritePlatformFileEilPKci
fun:_ZN10disk_cache22SimpleSynchronousEntry9WriteDataEiiPN3net8IOBufferEibPi
}
{
bug_245092a
Memcheck:Leak
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment