Commit 32cf68a0 authored by Avery Musbach's avatar Avery Musbach Committed by Commit Bot

overview: Disable entering overview while dragging split view divider

You shall not be able to enter overview by pressing the overview button
with one finger, while dragging the split view divider with another
finger. See the video linked on Monorail.

Test: manual
Change-Id: I779e20fcc951d44355ee4c05d71e5bac1c83024f
Fixed: 1051758
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055735Reviewed-by: default avatarSammie Quon <sammiequon@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#741229}
parent dde134fe
...@@ -447,9 +447,11 @@ void OverviewController::ToggleOverview( ...@@ -447,9 +447,11 @@ void OverviewController::ToggleOverview(
} }
bool OverviewController::CanEnterOverview() { bool OverviewController::CanEnterOverview() {
// Prevent toggling overview during the split view divider snap animation. // Prevent entering overview while the divider is dragged or animated.
if (SplitViewController::Get(Shell::GetPrimaryRootWindow()) SplitViewController* split_view_controller =
->IsDividerAnimating()) { SplitViewController::Get(Shell::GetPrimaryRootWindow());
if (split_view_controller->is_resizing() ||
split_view_controller->IsDividerAnimating()) {
return false; return false;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment