Commit 32d2c24c authored by Etienne Bergeron's avatar Etienne Bergeron Committed by Commit Bot

Add a navigation category to slow-reports

Adding the navigation category to get better trace for omnibox debugging.

R=oysteine@chromium.org

Bug: 868419
Change-Id: I08842d4f8de7845f63a8add5ef2f10ab460b1ce5
Reviewed-on: https://chromium-review.googlesource.com/1153457Reviewed-by: default avataroysteine <oysteine@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578799}
parent 63d7be67
...@@ -35,6 +35,7 @@ const char kConfigCategoryBenchmarkMemoryHeavy[] = "BENCHMARK_MEMORY_HEAVY"; ...@@ -35,6 +35,7 @@ const char kConfigCategoryBenchmarkMemoryHeavy[] = "BENCHMARK_MEMORY_HEAVY";
const char kConfigCategoryBenchmarkMemoryLight[] = "BENCHMARK_MEMORY_LIGHT"; const char kConfigCategoryBenchmarkMemoryLight[] = "BENCHMARK_MEMORY_LIGHT";
const char kConfigCategoryBenchmarkExecutionMetric[] = const char kConfigCategoryBenchmarkExecutionMetric[] =
"BENCHMARK_EXECUTION_METRIC"; "BENCHMARK_EXECUTION_METRIC";
const char kConfigCategoryBenchmarkNavigation[] = "BENCHMARK_NAVIGATION";
const char kConfigCategoryBlinkStyle[] = "BLINK_STYLE"; const char kConfigCategoryBlinkStyle[] = "BLINK_STYLE";
} // namespace } // namespace
...@@ -67,6 +68,8 @@ std::string BackgroundTracingConfigImpl::CategoryPresetToString( ...@@ -67,6 +68,8 @@ std::string BackgroundTracingConfigImpl::CategoryPresetToString(
return kConfigCategoryBenchmarkMemoryLight; return kConfigCategoryBenchmarkMemoryLight;
case BackgroundTracingConfigImpl::BENCHMARK_EXECUTION_METRIC: case BackgroundTracingConfigImpl::BENCHMARK_EXECUTION_METRIC:
return kConfigCategoryBenchmarkExecutionMetric; return kConfigCategoryBenchmarkExecutionMetric;
case BackgroundTracingConfigImpl::BENCHMARK_NAVIGATION:
return kConfigCategoryBenchmarkNavigation;
case BackgroundTracingConfigImpl::BLINK_STYLE: case BackgroundTracingConfigImpl::BLINK_STYLE:
return kConfigCategoryBlinkStyle; return kConfigCategoryBlinkStyle;
case BackgroundTracingConfigImpl::CATEGORY_PRESET_UNSET: case BackgroundTracingConfigImpl::CATEGORY_PRESET_UNSET:
...@@ -124,6 +127,11 @@ bool BackgroundTracingConfigImpl::StringToCategoryPreset( ...@@ -124,6 +127,11 @@ bool BackgroundTracingConfigImpl::StringToCategoryPreset(
return true; return true;
} }
if (category_preset_string == kConfigCategoryBenchmarkNavigation) {
*category_preset = BackgroundTracingConfigImpl::BENCHMARK_NAVIGATION;
return true;
}
if (category_preset_string == kConfigCategoryBlinkStyle) { if (category_preset_string == kConfigCategoryBlinkStyle) {
*category_preset = BackgroundTracingConfigImpl::BLINK_STYLE; *category_preset = BackgroundTracingConfigImpl::BLINK_STYLE;
return true; return true;
...@@ -279,4 +287,4 @@ BackgroundTracingConfigImpl::ReactiveFromDict( ...@@ -279,4 +287,4 @@ BackgroundTracingConfigImpl::ReactiveFromDict(
return config; return config;
} }
} // namspace content } // namespace content
...@@ -37,6 +37,7 @@ class CONTENT_EXPORT BackgroundTracingConfigImpl ...@@ -37,6 +37,7 @@ class CONTENT_EXPORT BackgroundTracingConfigImpl
BENCHMARK_MEMORY_HEAVY, BENCHMARK_MEMORY_HEAVY,
BENCHMARK_MEMORY_LIGHT, BENCHMARK_MEMORY_LIGHT,
BENCHMARK_EXECUTION_METRIC, BENCHMARK_EXECUTION_METRIC,
BENCHMARK_NAVIGATION,
BLINK_STYLE BLINK_STYLE
}; };
......
...@@ -287,6 +287,7 @@ TEST_F(BackgroundTracingConfigTest, ValidPreemptiveCategoryToString) { ...@@ -287,6 +287,7 @@ TEST_F(BackgroundTracingConfigTest, ValidPreemptiveCategoryToString) {
BackgroundTracingConfigImpl::BENCHMARK_MEMORY_HEAVY, BackgroundTracingConfigImpl::BENCHMARK_MEMORY_HEAVY,
BackgroundTracingConfigImpl::BENCHMARK_MEMORY_LIGHT, BackgroundTracingConfigImpl::BENCHMARK_MEMORY_LIGHT,
BackgroundTracingConfigImpl::BENCHMARK_EXECUTION_METRIC, BackgroundTracingConfigImpl::BENCHMARK_EXECUTION_METRIC,
BackgroundTracingConfigImpl::BENCHMARK_NAVIGATION,
BackgroundTracingConfigImpl::BLINK_STYLE, BackgroundTracingConfigImpl::BLINK_STYLE,
}; };
...@@ -299,6 +300,7 @@ TEST_F(BackgroundTracingConfigTest, ValidPreemptiveCategoryToString) { ...@@ -299,6 +300,7 @@ TEST_F(BackgroundTracingConfigTest, ValidPreemptiveCategoryToString) {
"BENCHMARK_MEMORY_HEAVY", "BENCHMARK_MEMORY_HEAVY",
"BENCHMARK_MEMORY_LIGHT", "BENCHMARK_MEMORY_LIGHT",
"BENCHMARK_EXECUTION_METRIC", "BENCHMARK_EXECUTION_METRIC",
"BENCHMARK_NAVIGATION",
"BLINK_STYLE"}; "BLINK_STYLE"};
for (size_t i = 0; for (size_t i = 0;
i < i <
...@@ -630,4 +632,4 @@ TEST_F(BackgroundTracingConfigTest, ValidReactiveConfigToString) { ...@@ -630,4 +632,4 @@ TEST_F(BackgroundTracingConfigTest, ValidReactiveConfigToString) {
} }
} }
} // namspace content } // namespace content
...@@ -650,6 +650,8 @@ BackgroundTracingManagerImpl::GetCategoryFilterStringForCategoryPreset( ...@@ -650,6 +650,8 @@ BackgroundTracingManagerImpl::GetCategoryFilterStringForCategoryPreset(
case BackgroundTracingConfigImpl::CategoryPreset:: case BackgroundTracingConfigImpl::CategoryPreset::
BENCHMARK_EXECUTION_METRIC: BENCHMARK_EXECUTION_METRIC:
return "blink.console,v8"; return "blink.console,v8";
case BackgroundTracingConfigImpl::CategoryPreset::BENCHMARK_NAVIGATION:
return "benchmark,toplevel,ipc,base,browser,navigation,omnibox";
case BackgroundTracingConfigImpl::CategoryPreset::BLINK_STYLE: case BackgroundTracingConfigImpl::CategoryPreset::BLINK_STYLE:
return "blink_style"; return "blink_style";
case BackgroundTracingConfigImpl::CategoryPreset::CATEGORY_PRESET_UNSET: case BackgroundTracingConfigImpl::CategoryPreset::CATEGORY_PRESET_UNSET:
...@@ -659,4 +661,4 @@ BackgroundTracingManagerImpl::GetCategoryFilterStringForCategoryPreset( ...@@ -659,4 +661,4 @@ BackgroundTracingManagerImpl::GetCategoryFilterStringForCategoryPreset(
return ""; return "";
} }
} // namspace content } // namespace content
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment