Use view controller containment for omnibox popup. Fix rotation bug.

Uses proper view controller containment APIs when displaying the popup.
Updates layout on screen rotation.

Bug: 837006
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ie7ff928d68b5cedc526cbe6057e1286cb54bd637
Reviewed-on: https://chromium-review.googlesource.com/1106175Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568793}

ios/chrome/browser/ui/omnibox/popup/omnibox_popup_positioner.h

@@ -13,6 +13,9 @@
 // View to which the popup view should be added as subview.
 - (UIView*)popupParentView;
 
+// The view controller that will parent the popup.
+- (UIViewController*)popupParentViewController;
+
 @end
 
 #endif  // IOS_CHROME_BROWSER_UI_OMNIBOX_OMNIBOX_POPUP_POSITIONER_H_

ios/chrome/browser/ui/omnibox/popup/omnibox_popup_presenter.mm

@@ -86,7 +86,11 @@ NS_INLINE CGFloat BottomPadding() {
 - (void)updateHeightAndAnimateAppearanceIfNecessary {
   UIView* popup = self.popupContainerView;
   if (!popup.superview) {
+    UIViewController* parentVC = [self.positioner popupParentViewController];
+    [parentVC addChildViewController:self.viewController];
     [[self.positioner popupParentView] addSubview:popup];
+    [self.viewController didMoveToParentViewController:parentVC];
+
     [self initialLayout];
   }
 
@@ -108,6 +112,7 @@ NS_INLINE CGFloat BottomPadding() {
 
 - (void)animateCollapse {
   UIView* retainedPopupView = self.popupContainerView;
+  UIViewController* retainedViewController = self.viewController;
   if (!IsIPadIdiom()) {
     self.bottomConstraint.active = NO;
   }
@@ -119,7 +124,9 @@ NS_INLINE CGFloat BottomPadding() {
         [[self.popupContainerView superview] layoutIfNeeded];
       }
       completion:^(BOOL) {
+        [retainedViewController willMoveToParentViewController:nil];
         [retainedPopupView removeFromSuperview];
+        [retainedViewController removeFromParentViewController];
       }];
 }
 

ios/chrome/browser/ui/omnibox/popup/omnibox_popup_view_controller.mm

@@ -171,6 +171,17 @@ UIColor* BackgroundColorIncognito() {
   [self layoutRows];
 }
 
+- (void)viewWillTransitionToSize:(CGSize)size
+       withTransitionCoordinator:
+           (id<UIViewControllerTransitionCoordinator>)coordinator {
+  [super viewWillTransitionToSize:size withTransitionCoordinator:coordinator];
+  [coordinator animateAlongsideTransition:^(
+                   id<UIViewControllerTransitionCoordinatorContext> context) {
+    [self layoutRows];
+  }
+                               completion:nil];
+}
+
 #pragma mark - Properties accessors
 
 - (void)setIncognito:(BOOL)incognito {

ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm

@@ -165,6 +165,10 @@
   return self.viewController.view.superview;
 }
 
+- (UIViewController*)popupParentViewController {
+  return self.viewController.parentViewController;
+}
+
 #pragma mark - Protected override
 
 - (void)updateToolbarForSideSwipeSnapshot:(web::WebState*)webState {

ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm

@@ -295,6 +295,10 @@ initWithToolsMenuConfigurationProvider:
   return self.toolbarViewController.view.superview;
 }
 
+- (UIViewController*)popupParentViewController {
+  return self.toolbarViewController.parentViewController;
+}
+
 #pragma mark - ToolsMenuPresentationStateProvider
 
 - (BOOL)isShowingToolsMenu {