Fix leak in JsSyncManagerObserver

This leak was introduced in r148926.

BUG=129825,139635


Review URL: https://chromiumcodereview.appspot.com/10821091

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@149062 0039d316-1c4b-4281-b951-d872f2087c98

sync/internal_api/js_sync_manager_observer.cc

@@ -131,10 +131,12 @@ void JsSyncManagerObserver::OnInitializationComplete(
   // Ignore the |js_backend| argument; it's not really convertible to
   // JSON anyway.
 
-  DictionaryValue* details = new DictionaryValue();
-  details->Set("restoredTypes", ModelTypeSetToValue(restored_types));
+  DictionaryValue details;
+  details.Set("restoredTypes", ModelTypeSetToValue(restored_types));
 
-  HandleJsEvent(FROM_HERE, "onInitializationComplete", JsEventDetails(details));
+  HandleJsEvent(FROM_HERE,
+                "onInitializationComplete",
+                JsEventDetails(&details));
 }
 
 void JsSyncManagerObserver::OnStopSyncingPermanently() {

tools/valgrind/memcheck/suppressions.txt

@@ -5761,21 +5761,6 @@
    fun:_ZN7WebCore12WorkerThread12runEventLoopEv
    fun:_ZN7WebCore21DedicatedWorkerThread12runEventLoopEv
 }
-{
-   bug_139635
-   Memcheck:Leak
-   fun:_Znw*
-   fun:_ZN6syncer21JsSyncManagerObserver24OnInitializationCompleteERKNS_10WeakHandleINS_9JsBackendEEEbNS_7EnumSetINS_9ModelTypeELS7_2ELS7_16EEE
-   fun:_ZN6syncer12_GLOBAL__N_155JsSyncManagerObserverTest_OnInitializationComplete_Test8TestBodyEv
-}
-{
-   bug_139635a
-   Memcheck:Leak
-   fun:_Znw*
-   fun:_ZN6syncer21JsSyncManagerObserver24OnInitializationCompleteERKNS_10WeakHandleINS_9JsBackendEEEbNS_7EnumSetINS_9ModelTypeELS7_2ELS7_16EEE
-   fun:_ZN6syncer15SyncManagerImpl4Init*
-   fun:_ZN12browser_sync15SyncBackendHost4Core12DoInitializeERKNS0_19DoInitializeOptionsE
-}
 {
    bug_139662
    Memcheck:Uninitialized