Add comment for fix to issue 95619

The fix is very subtle.  We need the comment to ensure we don't accidentally
revert the fix.  It's also a helpful reminder that we should try to find a less
brittle solution.

BUG=95619
TEST=None


Review URL: http://codereview.chromium.org/7995015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@102436 0039d316-1c4b-4281-b951-d872f2087c98
parent 7a51f364
...@@ -1030,6 +1030,9 @@ bool ProfileSyncServiceHarness::EnableEncryptionForType( ...@@ -1030,6 +1030,9 @@ bool ProfileSyncServiceHarness::EnableEncryptionForType(
bool ProfileSyncServiceHarness::WaitForTypeEncryption( bool ProfileSyncServiceHarness::WaitForTypeEncryption(
syncable::ModelType type) { syncable::ModelType type) {
// The correctness of this if condition depends on the ordering of its
// sub-expressions. See crbug.com/95619.
// TODO(rlarocque): Figure out a less brittle way of detecting this.
if (IsTypeEncrypted(type) && if (IsTypeEncrypted(type) &&
IsSynced() && IsSynced() &&
GetLastSessionSnapshot()->num_conflicting_updates == 0) { GetLastSessionSnapshot()->num_conflicting_updates == 0) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment