[html] reflection.js should not test default values if customGetter is specified.

Bug: crbug.com/894661
Change-Id: I1df3af43ec2818f181eff99277c1d14c0dd3bb63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1502772
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Auto-Submit: Kent Tamura <tkent@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#638102}

third_party/blink/web_tests/external/wpt/html/dom/reflection-embedded-expected.txt

 This is a testharness.js-based test.
-Found 7087 tests; 6958 PASS, 129 FAIL, 0 TIMEOUT, 0 NOTRUN.
+Found 7085 tests; 6956 PASS, 129 FAIL, 0 TIMEOUT, 0 NOTRUN.
 PASS picture.title: 32 tests
 PASS picture.lang: 32 tests
 PASS picture.dir: 62 tests
@@ -20,8 +20,8 @@ PASS img.srcset: 32 tests
 PASS img.crossOrigin: 52 tests
 PASS img.useMap: 32 tests
 PASS img.isMap: 33 tests
-PASS img.width: 9 tests
-PASS img.height: 9 tests
+PASS img.width: 8 tests
+PASS img.height: 8 tests
 PASS img.referrerPolicy: 27 tests
 FAIL img.referrerPolicy: setAttribute() to "same-origin" assert_equals: IDL get expected "same-origin" but got ""
 PASS img.referrerPolicy: 3 tests

third_party/blink/web_tests/external/wpt/html/dom/reflection-forms-expected.txt

-This is a testharness.js-based test.
-Found 6725 tests; 6722 PASS, 3 FAIL, 0 TIMEOUT, 0 NOTRUN.
-PASS form.title: 32 tests
-PASS form.lang: 32 tests
-PASS form.dir: 62 tests
-PASS form.className (<form class>): 32 tests
-PASS form.hidden: 33 tests
-PASS form.accessKey: 32 tests
-PASS form.tabIndex: 24 tests
-PASS form.acceptCharset (<form accept-charset>): 32 tests
-PASS form.action: 38 tests
-PASS form.autocomplete: 52 tests
-PASS form.enctype: 62 tests
-PASS form.encoding (<form enctype>): 62 tests
-PASS form.method: 62 tests
-PASS form.name: 32 tests
-PASS form.noValidate: 33 tests
-PASS form.target: 32 tests
-PASS fieldset.title: 32 tests
-PASS fieldset.lang: 32 tests
-PASS fieldset.dir: 62 tests
-PASS fieldset.className (<fieldset class>): 32 tests
-PASS fieldset.hidden: 33 tests
-PASS fieldset.accessKey: 32 tests
-PASS fieldset.tabIndex: 24 tests
-PASS fieldset.disabled: 33 tests
-PASS fieldset.name: 32 tests
-PASS legend.title: 32 tests
-PASS legend.lang: 32 tests
-PASS legend.dir: 62 tests
-PASS legend.className (<legend class>): 32 tests
-PASS legend.hidden: 33 tests
-PASS legend.accessKey: 32 tests
-PASS legend.tabIndex: 24 tests
-PASS legend.align: 32 tests
-PASS label.title: 32 tests
-PASS label.lang: 32 tests
-PASS label.dir: 62 tests
-PASS label.className (<label class>): 32 tests
-PASS label.hidden: 33 tests
-PASS label.accessKey: 32 tests
-PASS label.tabIndex: 24 tests
-PASS label.htmlFor (<label for>): 32 tests
-PASS input.title: 32 tests
-PASS input.lang: 32 tests
-PASS input.dir: 62 tests
-PASS input.className (<input class>): 32 tests
-PASS input.hidden: 33 tests
-PASS input.accessKey: 32 tests
-PASS input.tabIndex: 24 tests
-PASS input.accept: 32 tests
-PASS input.alt: 32 tests
-PASS input.autocomplete: 17 tests
-PASS input.autofocus: 33 tests
-PASS input.defaultChecked (<input checked>): 33 tests
-PASS input.dirName: 32 tests
-PASS input.disabled: 33 tests
-PASS input.formAction: 38 tests
-PASS input.formEnctype: 62 tests
-PASS input.formMethod: 52 tests
-PASS input.formNoValidate: 33 tests
-PASS input.formTarget: 32 tests
-PASS input.height: 9 tests
-PASS input.max: 32 tests
-PASS input.maxLength: 61 tests
-PASS input.min: 32 tests
-PASS input.minLength: 61 tests
-PASS input.multiple: 33 tests
-PASS input.name: 32 tests
-PASS input.pattern: 32 tests
-PASS input.placeholder: 32 tests
-PASS input.readOnly: 33 tests
-PASS input.required: 33 tests
-PASS input.size: 59 tests
-PASS input.src: 38 tests
-PASS input.step: 32 tests
-PASS input.type: 256 tests
-PASS input.width: 9 tests
-PASS input.defaultValue (<input value>): 32 tests
-PASS input.align: 32 tests
-PASS input.useMap: 32 tests
-PASS button.title: 32 tests
-PASS button.lang: 32 tests
-PASS button.dir: 62 tests
-PASS button.className (<button class>): 32 tests
-PASS button.hidden: 33 tests
-PASS button.accessKey: 32 tests
-PASS button.tabIndex: 24 tests
-PASS button.autofocus: 33 tests
-PASS button.disabled: 33 tests
-PASS button.formAction: 38 tests
-PASS button.formEnctype: 62 tests
-PASS button.formMethod: 62 tests
-PASS button.formNoValidate: 33 tests
-PASS button.formTarget: 32 tests
-PASS button.name: 32 tests
-PASS button.type: 62 tests
-PASS button.value: 32 tests
-PASS select.title: 32 tests
-PASS select.lang: 32 tests
-PASS select.dir: 62 tests
-PASS select.className (<select class>): 32 tests
-PASS select.hidden: 33 tests
-PASS select.accessKey: 32 tests
-PASS select.tabIndex: 24 tests
-PASS select.autocomplete: 17 tests
-PASS select.autofocus: 33 tests
-PASS select.disabled: 33 tests
-PASS select.multiple: 33 tests
-PASS select.name: 32 tests
-PASS select.required: 33 tests
-PASS select.size: 62 tests
-PASS datalist.title: 32 tests
-PASS datalist.lang: 32 tests
-PASS datalist.dir: 62 tests
-PASS datalist.className (<datalist class>): 32 tests
-PASS datalist.hidden: 33 tests
-PASS datalist.accessKey: 32 tests
-PASS datalist.tabIndex: 24 tests
-PASS optgroup.title: 32 tests
-PASS optgroup.lang: 32 tests
-PASS optgroup.dir: 62 tests
-PASS optgroup.className (<optgroup class>): 32 tests
-PASS optgroup.hidden: 33 tests
-PASS optgroup.accessKey: 32 tests
-PASS optgroup.tabIndex: 24 tests
-PASS optgroup.disabled: 33 tests
-PASS optgroup.label: 32 tests
-PASS option.title: 32 tests
-PASS option.lang: 32 tests
-PASS option.dir: 62 tests
-PASS option.className (<option class>): 32 tests
-PASS option.hidden: 33 tests
-PASS option.accessKey: 32 tests
-PASS option.tabIndex: 24 tests
-PASS option.disabled: 33 tests
-PASS option.label: 17 tests
-PASS option.defaultSelected (<option selected>): 33 tests
-PASS option.value: 17 tests
-PASS textarea.title: 32 tests
-PASS textarea.lang: 32 tests
-PASS textarea.dir: 62 tests
-PASS textarea.className (<textarea class>): 32 tests
-PASS textarea.hidden: 33 tests
-PASS textarea.accessKey: 32 tests
-PASS textarea.tabIndex: 24 tests
-PASS textarea.autocomplete: 17 tests
-PASS textarea.autofocus: 33 tests
-PASS textarea.cols: 59 tests
-PASS textarea.dirName: 32 tests
-PASS textarea.disabled: 33 tests
-PASS textarea.maxLength: 61 tests
-PASS textarea.minLength: 61 tests
-PASS textarea.name: 32 tests
-PASS textarea.placeholder: 32 tests
-PASS textarea.readOnly: 33 tests
-PASS textarea.required: 33 tests
-PASS textarea.rows: 59 tests
-PASS textarea.wrap: 32 tests
-PASS output.title: 32 tests
-PASS output.lang: 32 tests
-PASS output.dir: 62 tests
-PASS output.className (<output class>): 32 tests
-PASS output.hidden: 33 tests
-PASS output.accessKey: 32 tests
-PASS output.tabIndex: 24 tests
-PASS output.name: 32 tests
-PASS progress.title: 32 tests
-PASS progress.lang: 32 tests
-PASS progress.dir: 62 tests
-PASS progress.className (<progress class>): 32 tests
-PASS progress.hidden: 33 tests
-PASS progress.accessKey: 32 tests
-PASS progress.tabIndex: 24 tests
-PASS meter.title: 32 tests
-PASS meter.lang: 32 tests
-PASS meter.dir: 62 tests
-PASS meter.className (<meter class>): 32 tests
-PASS meter.hidden: 33 tests
-PASS meter.accessKey: 32 tests
-PASS meter.tabIndex: 24 tests
-PASS meter.value: 8 tests
-PASS meter.min: 8 tests
-PASS meter.max: typeof IDL attribute
-FAIL meter.max: IDL get with DOM attribute unset assert_equals: expected 0 but got 1
-PASS meter.max: 6 tests
-PASS meter.low: 8 tests
-PASS meter.high: typeof IDL attribute
-FAIL meter.high: IDL get with DOM attribute unset assert_equals: expected 0 but got 1
-PASS meter.high: 6 tests
-PASS meter.optimum: typeof IDL attribute
-FAIL meter.optimum: IDL get with DOM attribute unset assert_equals: expected 0 but got 0.5
-PASS meter.optimum: 6 tests
-Harness: the test ran to completion.
-

third_party/blink/web_tests/external/wpt/html/dom/reflection-metadata-expected.txt

 This is a testharness.js-based test.
-Found 2446 tests; 2365 PASS, 81 FAIL, 0 TIMEOUT, 0 NOTRUN.
+Found 2445 tests; 2365 PASS, 80 FAIL, 0 TIMEOUT, 0 NOTRUN.
 PASS head.title: 32 tests
 PASS head.lang: 32 tests
 PASS head.dir: 62 tests
@@ -21,9 +21,7 @@ PASS base.className (<base class>): 32 tests
 PASS base.hidden: 33 tests
 PASS base.accessKey: 32 tests
 PASS base.tabIndex: 24 tests
-PASS base.href: typeof IDL attribute
-FAIL base.href: IDL get with DOM attribute unset assert_equals: expected "" but got "http://web-platform.test:8001/html/dom/reflection-metadata.html"
-PASS base.href: 18 tests
+PASS base.href: 19 tests
 PASS base.target: 32 tests
 PASS link.title: 32 tests
 PASS link.lang: 32 tests

third_party/blink/web_tests/external/wpt/html/dom/reflection.js

@@ -636,7 +636,7 @@ ReflectionTests.reflects = function(data, idlName, idlObj, domName, domObj) {
         // Hard-coded special case
         defaultVal = domObj.ownerDocument.URL;
     }
-    if (defaultVal !== null || data.isNullable) {
+    if (!data.customGetter && (defaultVal !== null || data.isNullable)) {
         ReflectionHarness.test(function() {
             ReflectionHarness.assertEquals(idlObj[idlName], defaultVal);
         }, "IDL get with DOM attribute unset");