Commit 330ee63c authored by Lijin Shen's avatar Lijin Shen Committed by Commit Bot

Add a command line argument of disabling default browser promo

This CL adds a command line argument to allow disabling default browser
promo on builds.

Bug: 1099714, 1090103
Change-Id: I7c2db4def8f0ea4b3572d94e3c495d3bdd3b8d13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277042
Commit-Queue: Lijin Shen <lazzzis@google.com>
Reviewed-by: default avatarPavel Yatsuk <pavely@chromium.org>
Reviewed-by: default avatarTheresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#784484}
parent 9f7072ec
......@@ -189,6 +189,10 @@ public abstract class ChromeSwitches {{
public static final String FEED_HEADER_MENU_IPH_TRIGGER_CONFIG =
"feed-header-menu-iph-trigger-config";
/** Disable the default browser promo. */
public static final String DISABLE_DEFAULT_BROWSER_PROMO =
"disable-default-browser-promo";
{NATIVE_STRINGS}
// Prevent instantiation.
......
......@@ -10,9 +10,11 @@ import android.text.TextUtils;
import androidx.annotation.IntDef;
import org.chromium.base.CommandLine;
import org.chromium.base.ContextUtils;
import org.chromium.base.PackageManagerUtils;
import org.chromium.chrome.browser.flags.ChromeFeatureList;
import org.chromium.chrome.browser.flags.ChromeSwitches;
import org.chromium.chrome.browser.lifecycle.ActivityLifecycleDispatcher;
import org.chromium.chrome.browser.preferences.ChromePreferenceKeys;
import org.chromium.chrome.browser.preferences.SharedPreferencesManager;
......@@ -74,6 +76,10 @@ public class DefaultBrowserPromoUtils {
return false;
}
if (CommandLine.getInstance().hasSwitch(ChromeSwitches.DISABLE_DEFAULT_BROWSER_PROMO)) {
return false;
}
// Criteria 1
int maxPromoCount = ChromeFeatureList.getFieldTrialParamByFeatureAsInt(
ChromeFeatureList.ANDROID_DEFAULT_BROWSER_PROMO, PROMO_COUNT_PARAM,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment