Commit 332ffb68 authored by Rohit Rao's avatar Rohit Rao Committed by Commit Bot

[ios] Updates TranslateInfobarModalOverlayMediatorTest for iOS 14.

Hard-coded language indexes need to be updated since the list of
supported languages changed in iOS 14.

BUG=1102968

Change-Id: I8ec7961dfcf2437840406894e47fc87444d7a5cc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285338
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: default avatarChris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#786041}
parent 71c73dfa
...@@ -4,6 +4,7 @@ ...@@ -4,6 +4,7 @@
#import "ios/chrome/browser/ui/overlays/infobar_modal/translate/translate_infobar_modal_overlay_mediator.h" #import "ios/chrome/browser/ui/overlays/infobar_modal/translate/translate_infobar_modal_overlay_mediator.h"
#include "base/ios/ios_util.h"
#include "base/strings/sys_string_conversions.h" #include "base/strings/sys_string_conversions.h"
#include "base/test/scoped_feature_list.h" #include "base/test/scoped_feature_list.h"
#include "components/infobars/core/infobar_feature.h" #include "components/infobars/core/infobar_feature.h"
...@@ -120,14 +121,20 @@ TEST_F(TranslateInfobarModalOverlayMediatorTest, ShowOriginalLanguage) { ...@@ -120,14 +121,20 @@ TEST_F(TranslateInfobarModalOverlayMediatorTest, ShowOriginalLanguage) {
// called, and didSelectSourceLanguageIndex and didSelectTargetLanguageIndex // called, and didSelectSourceLanguageIndex and didSelectTargetLanguageIndex
// were called beforehand to change the source and target languages. // were called beforehand to change the source and target languages.
TEST_F(TranslateInfobarModalOverlayMediatorTest, UpdateLanguageInfo) { TEST_F(TranslateInfobarModalOverlayMediatorTest, UpdateLanguageInfo) {
[mediator_ didSelectSourceLanguageIndex:69 withName:@"Portuguese"]; // Language indexes are different on iOS 14.
[mediator_ didSelectTargetLanguageIndex:83 withName:@"Spanish"]; // TODO(crbug.com/1102968): Avoid hard-coding indexes here.
const int portuguese_index = base::ios::IsRunningOnIOS14OrLater() ? 67 : 69;
const int spanish_index = base::ios::IsRunningOnIOS14OrLater() ? 81 : 83;
[mediator_ didSelectSourceLanguageIndex:portuguese_index
withName:@"Portuguese"];
[mediator_ didSelectTargetLanguageIndex:spanish_index withName:@"Spanish"];
request_->GetCallbackManager()->AddDispatchCallback(OverlayDispatchCallback( request_->GetCallbackManager()->AddDispatchCallback(OverlayDispatchCallback(
base::BindRepeating(^(OverlayResponse* response) { base::BindRepeating(^(OverlayResponse* response) {
UpdateLanguageInfo* info = response->GetInfo<UpdateLanguageInfo>(); UpdateLanguageInfo* info = response->GetInfo<UpdateLanguageInfo>();
ASSERT_TRUE(info); ASSERT_TRUE(info);
EXPECT_EQ(69, info->source_language_index()); EXPECT_EQ(portuguese_index, info->source_language_index());
EXPECT_EQ(83, info->target_language_index()); EXPECT_EQ(spanish_index, info->target_language_index());
}), }),
UpdateLanguageInfo::ResponseSupport())); UpdateLanguageInfo::ResponseSupport()));
EXPECT_CALL( EXPECT_CALL(
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment