Files app: Generate JS modules for //u/f/f/f/j/file_tasks.js

In //ui/file_manager/file_manager/foreground/js/:
- file_tasks.js
- file_tasks_unittest.m.js

Bug: 1133186
Change-Id: I9bfc94f7987e52df8135a19ae06355baa1dd8564
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627201Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Jeremie Boulic <jboulic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#843473}

chrome/browser/chromeos/file_manager/file_manager_jstest.cc

@@ -137,7 +137,7 @@ IN_PROC_BROWSER_TEST_F(FileManagerJsTest, FileTapHandler) {
 }
 
 IN_PROC_BROWSER_TEST_F(FileManagerJsTest, FileTasks) {
-  RunTestURL("foreground/js/file_tasks_unittest_gen.html");
+  RunTestURL("foreground/js/file_tasks_unittest.m_gen.html");
 }
 
 IN_PROC_BROWSER_TEST_F(FileManagerJsTest, FileTransferController) {

ui/file_manager/file_manager/background/js/BUILD.gn

@@ -349,6 +349,8 @@ js_library("mock_crostini.m") {
     ":crostini.m",
     "//ui/file_manager/externs/background:crostini.m",
   ]
+  visibility +=
+      [ "//ui/file_manager/file_manager/foreground/js:file_tasks_unittest.m" ]
 
   extra_deps = [ ":modulize" ]
 }
@@ -938,6 +940,8 @@ js_library("mock_progress_center.m") {
     "//ui/file_manager/externs/background:progress_center.m",
     "//ui/file_manager/file_manager/common/js:progress_center_common.m",
   ]
+  visibility +=
+      [ "//ui/file_manager/file_manager/foreground/js:file_tasks_unittest.m" ]
 
   extra_deps = [ ":modulize" ]
 }

ui/file_manager/file_manager/foreground/js/BUILD.gn

@@ -42,6 +42,7 @@ js_type_check("closure_compile_jsmodules") {
     ":fake_file_selection_handler.m",
     ":file_list_model.m",
     ":file_selection.m",
+    ":file_tasks.m",
     ":file_transfer_controller.m",
     ":file_type_filters_controller.m",
     ":file_watcher.m",
@@ -768,15 +769,66 @@ js_library("file_tasks") {
   ]
 }
 
-js_unittest("file_tasks_unittest") {
+js_library("file_tasks.m") {
+  sources = [
+    "$root_gen_dir/ui/file_manager/file_manager/foreground/js/file_tasks.m.js",
+  ]
   deps = [
-    ":file_tasks",
-    "metadata:mock_metadata",
-    "//ui/file_manager/base/js:mock_chrome",
-    "//ui/file_manager/base/js:test_error_reporting",
-    "//ui/file_manager/file_manager/background/js:mock_crostini",
-    "//ui/file_manager/file_manager/background/js:mock_progress_center",
-    "//ui/file_manager/file_manager/common/js:mock_entry",
+    ":constants.m",
+    ":directory_model.m",
+    ":file_transfer_controller.m",
+    ":naming_controller.m",
+    ":task_history.m",
+    ":web_store_utils.m",
+    "metadata:metadata_model.m",
+    "ui:combobutton.m",
+    "ui:default_task_dialog.m",
+    "ui:file_manager_ui.m",
+    "ui:files_confirm_dialog.m",
+    "ui:files_menu.m",
+    "ui:multi_menu_button.m",
+    "ui:suggest_apps_dialog.m",
+    "//ui/file_manager/base/js:volume_manager_types.m",
+    "//ui/file_manager/externs:volume_info.m",
+    "//ui/file_manager/externs:volume_manager.m",
+    "//ui/file_manager/externs/background:crostini.m",
+    "//ui/file_manager/externs/background:progress_center.m",
+    "//ui/file_manager/file_manager/common/js:async_util.m",
+    "//ui/file_manager/file_manager/common/js:file_type.m",
+    "//ui/file_manager/file_manager/common/js:metrics.m",
+    "//ui/file_manager/file_manager/common/js:progress_center_common.m",
+    "//ui/file_manager/file_manager/common/js:util.m",
+    "//ui/file_manager/file_manager/foreground/elements:files_password_dialog.m",
+    "//ui/webui/resources/js:assert.m",
+    "//ui/webui/resources/js:load_time_data.m",
+    "//ui/webui/resources/js/cr:ui.m",
+    "//ui/webui/resources/js/cr/ui:menu.m",
+  ]
+
+  extra_deps = [ ":modulize" ]
+}
+
+js_unittest("file_tasks_unittest.m") {
+  deps = [
+    ":directory_model.m",
+    ":file_tasks.m",
+    ":file_transfer_controller.m",
+    ":naming_controller.m",
+    ":task_history.m",
+    "metadata:metadata_model.m",
+    "ui:file_manager_ui.m",
+    "//chrome/test/data/webui:chai_assert",
+    "//ui/file_manager/base/js:mock_chrome.m",
+    "//ui/file_manager/base/js:test_error_reporting.m",
+    "//ui/file_manager/base/js:volume_manager_types.m",
+    "//ui/file_manager/externs:entry_location.m",
+    "//ui/file_manager/externs:volume_manager.m",
+    "//ui/file_manager/externs/background:progress_center.m",
+    "//ui/file_manager/file_manager/background/js:mock_crostini.m",
+    "//ui/file_manager/file_manager/background/js:mock_progress_center.m",
+    "//ui/file_manager/file_manager/common/js:mock_entry.m",
+    "//ui/file_manager/file_manager/common/js:progress_center_common.m",
+    "//ui/file_manager/file_manager/foreground/elements:files_password_dialog.m",
   ]
 }
 
@@ -1498,10 +1550,12 @@ js_library("webui_command_extender.m") {
 }
 
 js_test_gen_html("js_test_gen_html_modules") {
+  is_polymer3 = true
   deps = [
     ":actions_model_unittest.m",
     ":directory_contents_unittest.m",
     ":file_list_model_unittest.m",
+    ":file_tasks_unittest.m",
     ":file_transfer_controller_unittest.m",
     ":file_type_filters_controller_unittest.m",
     ":list_thumbnail_loader_unittest.m",
@@ -1510,7 +1564,6 @@ js_test_gen_html("js_test_gen_html_modules") {
     ":spinner_controller_unittest.m",
     ":thumbnail_loader_unittest.m",
   ]
-  js_module = true
 
   closure_flags =
       strict_error_checking_closure_args + [
@@ -1526,7 +1579,6 @@ js_test_gen_html("js_test_gen_html_modules") {
 js_test_gen_html("js_test_gen_html") {
   deps = [
     ":file_manager_commands_unittest",
-    ":file_tasks_unittest",
     ":import_controller_unittest",
     ":task_controller_unittest",
   ]
@@ -1577,10 +1629,13 @@ js_modulizer("modulize") {
     "webui_command_extender.js",
     "sort_menu_controller.js",
     "selection_menu_controller.js",
+    "file_tasks.js",
   ]
 
   namespace_rewrites = cr_namespace_rewrites + [
                          "cr.ui.FilesMenuItem|FilesMenuItem",
                          "cr.ui.MultiMenu|MultiMenu",
+                         "cr.ui.ComboButton|ComboButton",
+                         "cr.filebrowser.DefaultTaskDialog|DefaultTaskDialog",
                        ]
 }

ui/file_manager/file_manager/foreground/js/file_tasks.js

@@ -2,11 +2,43 @@
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+// clang-format off
+// #import {Menu} from 'chrome://resources/js/cr/ui/menu.m.js';
+// #import {MultiMenuButton} from './ui/multi_menu_button.m.js';
+// #import {VolumeInfo} from '../../../externs/volume_info.m.js';
+// #import {ProgressCenter} from '../../../externs/background/progress_center.m.js';
+// #import {Crostini} from '../../../externs/background/crostini.m.js';
+// #import {NamingController} from './naming_controller.m.js';
+// #import {TaskHistory} from './task_history.m.js';
+// #import {FileManagerUI} from './ui/file_manager_ui.m.js';
+// #import {DirectoryModel} from './directory_model.m.js';
+// #import {MetadataModel} from './metadata/metadata_model.m.js';
+// #import {VolumeManager} from '../../../externs/volume_manager.m.js';
+// #import {FilesMenuItem} from './ui/files_menu.m.js';
+// #import {decorate} from 'chrome://resources/js/cr/ui.m.js';
+// #import {FilesPasswordDialog} from '../elements/files_password_dialog.m.js';
+// #import {ProgressCenterItem, ProgressItemType, ProgressItemState} from '../../common/js/progress_center_common.m.js';
+// #import {webStoreUtils} from './web_store_utils.m.js';
+// #import {FileTransferController} from './file_transfer_controller.m.js';
+// #import {FilesConfirmDialog} from './ui/files_confirm_dialog.m.js';
+// #import {VolumeManagerCommon} from '../../../base/js/volume_manager_types.m.js';
+// #import {FileType} from '../../common/js/file_type.m.js';
+// #import {SuggestAppsDialog} from './ui/suggest_apps_dialog.m.js';
+// #import {constants} from './constants.m.js';
+// #import {util, strf, str} from '../../common/js/util.m.js';
+// #import {AsyncUtil} from '../../common/js/async_util.m.js'
+// #import {metrics} from '../../common/js/metrics.m.js';
+// #import {loadTimeData} from 'chrome://resources/js/load_time_data.m.js';
+// #import {assert} from 'chrome://resources/js/assert.m.js';
+// #import {DefaultTaskDialog} from './ui/default_task_dialog.m.js';
+// #import {ComboButton} from './ui/combobutton.m.js';
+// clang-format on
+
 /**
  * Represents a collection of available tasks to execute for a specific list
  * of entries.
  */
-class FileTasks {
+/* #export */ class FileTasks {
   /**
    * @param {!VolumeManager} volumeManager
    * @param {!MetadataModel} metadataModel

ui/file_manager/file_manager/foreground/js/ui/BUILD.gn

@@ -926,6 +926,7 @@ js_library("location_line") {
 js_library("location_line.m") {
   sources = [ "$root_gen_dir/ui/file_manager/file_manager/foreground/js/ui/location_line.m.js" ]
   deps = [
+    ":breadcrumb.m",
     ":list_container.m",
     "//ui/file_manager/externs:files_app_entry_interfaces.m",
     "//ui/file_manager/externs:volume_manager.m",

ui/file_manager/file_manager/foreground/js/ui/location_line.js

@@ -11,6 +11,7 @@
 // #import {PathComponent} from '../path_component.m.js';
 // #import {NativeEventTarget as EventTarget} from 'chrome://resources/js/cr/event_target.m.js';
 // #import {metrics} from '../../../common/js/metrics.m.js';
+// #import './breadcrumb.m.js';
 // clang-format on
 
 /**