Commit 334c21c5 authored by Alex Clarke's avatar Alex Clarke

Make layout test debugging easier

Layout test debugging is much easier if we can see the task logging in
the driver output. Running with verbose logging is too spamy

I'm forever making and reverting this change locally, lets land it.

Change-Id: I6df5ff3757b92a9001ef67b25d090bc967a05d65
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751186Reviewed-by: default avatarSami Kyöstilä <skyostil@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686375}
parent de827289
......@@ -518,14 +518,14 @@ void SequenceManagerImpl::LogTaskDebugInfo(
break;
case Settings::TaskLogging::kEnabled:
DVLOG(1) << "#"
<< static_cast<uint64_t>(
executing_task.pending_task.enqueue_order())
<< " " << executing_task.task_queue_name
<< (executing_task.pending_task.cross_thread_
? " Run crossthread "
: " Run ")
<< executing_task.pending_task.posted_from.ToString();
LOG(INFO) << "#"
<< static_cast<uint64_t>(
executing_task.pending_task.enqueue_order())
<< " " << executing_task.task_queue_name
<< (executing_task.pending_task.cross_thread_
? " Run crossthread "
: " Run ")
<< executing_task.pending_task.posted_from.ToString();
break;
case Settings::TaskLogging::kEnabledWithBacktrace: {
......@@ -539,14 +539,14 @@ void SequenceManagerImpl::LogTaskDebugInfo(
++length;
if (length == 0)
break;
DVLOG(1) << "#"
<< static_cast<uint64_t>(
executing_task.pending_task.enqueue_order())
<< " " << executing_task.task_queue_name
<< (executing_task.pending_task.cross_thread_
? " Run crossthread "
: " Run ")
<< debug::StackTrace(task_trace.data(), length);
LOG(INFO) << "#"
<< static_cast<uint64_t>(
executing_task.pending_task.enqueue_order())
<< " " << executing_task.task_queue_name
<< (executing_task.pending_task.cross_thread_
? " Run crossthread "
: " Run ")
<< debug::StackTrace(task_trace.data(), length);
break;
}
}
......
......@@ -230,8 +230,8 @@ void TaskQueueImpl::MaybeLogPostTask(PostedTask* task) {
if (!sequence_manager_->settings().log_post_task)
return;
DVLOG(1) << name_ << " PostTask " << task->location.ToString() << " delay "
<< task->delay;
LOG(INFO) << name_ << " PostTask " << task->location.ToString() << " delay "
<< task->delay;
#endif // DCHECK_IS_ON()
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment