Commit 339ab972 authored by Nico Weber's avatar Nico Weber Committed by Commit Bot

Don't run string_number_conversion_test.cc on win/asan/dll again.

Reapplies https://chromium-review.googlesource.com/c/chromium/src/+/757880,
which got removed in https://chromium-review.googlesource.com/c/762380/ when
we removed all crashpad_tests from all win/asan bots.  crashpad_tests runs
on the win/asan bots again, so this one test needs to be disabled again.

(See bug; root cause bugs.llvm.org/PR35137)

Bug: 856174
Change-Id: I0796efd9ba306ea5a304a5ae85eeb4af9eec656e
Reviewed-on: https://chromium-review.googlesource.com/1113664Reviewed-by: default avatarReid Kleckner <rnk@chromium.org>
Reviewed-by: default avatarRobert Sesek <rsesek@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#570163}
parent b3b5e3b9
...@@ -14,6 +14,10 @@ ...@@ -14,6 +14,10 @@
import("../build/crashpad_buildconfig.gni") import("../build/crashpad_buildconfig.gni")
if (crashpad_is_in_chromium) {
import("//build/config/sanitizers/sanitizers.gni")
}
declare_args() { declare_args() {
use_boringssl_for_http_transport_socket = crashpad_is_fuchsia use_boringssl_for_http_transport_socket = crashpad_is_fuchsia
} }
...@@ -636,6 +640,13 @@ source_set("util_test") { ...@@ -636,6 +640,13 @@ source_set("util_test") {
"win/scoped_process_suspend_test.cc", "win/scoped_process_suspend_test.cc",
"win/session_end_watcher_test.cc", "win/session_end_watcher_test.cc",
] ]
if (crashpad_is_in_chromium) {
if (is_asan && is_component_build) {
# TODO(crbug.com/856174): Re-enable these once Windows ASan is fixed.
sources -= [ "stdlib/string_number_conversion_test.cc" ]
}
}
} }
data = [ data = [
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment