Fix leak; remove "explicit" keyword from multi-argument constructor.

BUG=106529
TEST=removed suppressions from mem/heap check tools


Review URL: http://codereview.chromium.org/8819029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@113293 0039d316-1c4b-4281-b951-d872f2087c98

chrome/browser/extensions/api/socket/socket_api_controller.cc

@@ -22,8 +22,8 @@ namespace extensions {
 // we need to manage it in the context of an extension.
 class Socket {
  public:
-  explicit Socket(const Profile* profile, const std::string& src_extension_id,
-                  const GURL& src_url);
+  Socket(const Profile* profile, const std::string& src_extension_id,
+         const GURL& src_url);
   ~Socket();
 
   bool Connect(const net::IPEndPoint& ip_end_point);
@@ -38,7 +38,7 @@ class Socket {
   std::string src_extension_id_;
   GURL src_url_;
 
-  net::UDPClientSocket* udp_client_socket_;
+  scoped_ptr<net::UDPClientSocket> udp_client_socket_;
   bool is_connected_;
   net::OldCompletionCallbackImpl<Socket> io_callback_;
 

tools/heapcheck/suppressions.txt

@@ -1785,17 +1785,3 @@
    fun:AccessibilityEventRouterViewsTest::CreateWindowWithContents
    fun:AccessibilityEventRouterViewsTest_TestFocusNotification_Test::TestBody
 }
-{
-   bug_106529_a
-   Heapcheck:Leak
-   ...
-   fun:extensions::SocketController::ConnectUdp
-   fun:extensions::SocketApiControllerTest_TestSocketControllerLifetime_Test::TestBody
-}
-{
-   bug_106529_b
-   Heapcheck:Leak
-   ...
-   fun:extensions::SocketController::CreateUdp
-   fun:extensions::SocketApiControllerTest_TestSocketControllerLifetime_Test::TestBody
-}

tools/valgrind/memcheck/suppressions.txt

@@ -5368,14 +5368,6 @@
    fun:_ZN5ppapi5proxy38EnterHostFromHostResourceForceCallbackINS_5thunk18PPB_Graphics2D_APIEEC1IN2pp25CompletionCallbackFactoryINS0_20PPB_Graphics2D_ProxyENS0_26ProxyNonThreadSafeRefCountEEEMS8_FviRKNS_12HostResourceEESB_EESD_RT_T0_RKT1_
    fun:_ZN5ppapi5proxy20PPB_Graphics2D_Proxy14OnHostMsgFlushERKNS_12HostResourceE
 }
-{
-   bug_106529
-   Memcheck:Leak
-   fun:_Znw*
-   fun:_ZN10extensions6SocketC?EPK7ProfileRKSsRK4GURL
-   fun:_ZN10extensions16SocketController9CreateUdpEPK7ProfileRKSsRK4GURL
-   fun:_ZN10extensions57SocketApiControllerTest_TestSocketControllerLifetime_Test8TestBodyEv
-}
 {
    bug_106549
    Memcheck:Uninitialized