Commit 33b31445 authored by Avery Musbach's avatar Avery Musbach Committed by Commit Bot

home_screen: Fix incorrect usage of base::UserMetricsAction

The argument to base::UserMetricsAction should always be a string
literal. See the comment where base::UserMetricsAction is defined.

Bug: 872319
Change-Id: I1b9de6000b06f51df5c429c3ceabf49607ef8a2d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2092874Reviewed-by: default avatarSammie Quon <sammiequon@chromium.org>
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Cr-Commit-Position: refs/heads/master@{#747986}
parent 00cc7399
...@@ -785,10 +785,11 @@ bool HomeLauncherGestureHandler::SetUpWindows(Mode mode, aura::Window* window) { ...@@ -785,10 +785,11 @@ bool HomeLauncherGestureHandler::SetUpWindows(Mode mode, aura::Window* window) {
DCHECK(base::Contains(windows, first_window)); DCHECK(base::Contains(windows, first_window));
DCHECK_NE(Mode::kNone, mode); DCHECK_NE(Mode::kNone, mode);
base::RecordAction(base::UserMetricsAction( base::RecordAction(
mode == Mode::kSlideDownToHide mode == Mode::kSlideDownToHide
? "AppList_HomeLauncherToMRUWindowAttempt" ? base::UserMetricsAction("AppList_HomeLauncherToMRUWindowAttempt")
: "AppList_CurrentWindowToHomeLauncherAttempt")); : base::UserMetricsAction(
"AppList_CurrentWindowToHomeLauncherAttempt"));
active_window_ = std::make_unique<ScopedWindowModifier>(first_window); active_window_ = std::make_unique<ScopedWindowModifier>(first_window);
GetActiveWindow()->AddObserver(this); GetActiveWindow()->AddObserver(this);
base::EraseIf(windows, [this](aura::Window* elem) { base::EraseIf(windows, [this](aura::Window* elem) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment