Commit 33f7986e authored by Gil Dekel's avatar Gil Dekel Committed by Commit Bot

chromeos_camera: Remove VAAPI image decoder tests

Currently, the VA-API image decoder unittests for JPEG and WebPs are
piggybacking on mjpeg_decode_accelerator_unittest.cc. This CL removes
these tests from mjpeg_decode_accelerator_unittest's binary.

Note that we do not lose the VA-API image decoder unittests coverage
since they now have their own binary [1][2]

[1] https://crrev.com/c/1881631
[2] https://crrev.com/c/1913488

Bug: 986074
Test: Existing test runs and passes locally on an Eve.
Change-Id: I76e4308cb73b6cf89a468d003c0abe263336a005
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946708Reviewed-by: default avatarAndres Calderon Jaramillo <andrescj@chromium.org>
Reviewed-by: default avatarMiguel Casas <mcasas@chromium.org>
Commit-Queue: Gil Dekel <gildekel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#720812}
parent 08fb855d
......@@ -186,6 +186,9 @@ if (use_v4l2_codec || use_vaapi) {
if (use_vaapi) {
deps += [ "//media/gpu/vaapi" ]
}
# TODO(crbug.com/1029942): consider removing use_x11 support here. This is
# no longer needed.
if (use_x11) {
deps += [ "//ui/gfx/x" ]
}
......@@ -234,24 +237,13 @@ test("jpeg_decode_accelerator_unittest") {
]
data = [
"//media/test/data/peach_pi-1280x720.jpg",
"//media/test/data/peach_pi-40x23.jpg",
"//media/test/data/peach_pi-41x22.jpg",
"//media/test/data/peach_pi-41x23.jpg",
]
if (use_vaapi) {
deps += [
"//media/gpu/vaapi",
"//media/gpu/vaapi:jpeg_decoder_unit_test",
# TODO(crbug.com/986074): we should move this to its own executable, but
# this would imply creating a new Tast wrapper in Chrome OS. So, for
# convenience, we make the WebP tests run with the
# jpeg_decode_accelerator_unittest binary.
"//media/gpu/vaapi:webp_decoder_unit_test",
]
data += [ "//media/test/data/pixel-1280x720.jpg" ]
deps += [ "//media/gpu/vaapi" ]
}
# TODO(crbug.com/1029942): consider removing use_x11 support here. This is no
# longer needed.
if (use_x11) {
deps += [ "//ui/gfx/x" ]
}
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment