Commit 33ffeb0a authored by Justin Cohen's avatar Justin Cohen Committed by Commit Bot

ios: Disable ARQuickLook tests on iOS12/Xcode12b4.

XCUIElement queries used in ARQuickLook are broken on Xcode 12 beta 4
when running on the iOS 12 simulator.  Disable until Xcode is fixed.

This is a re-land of a reverted CL using testInvocations to disable
instead. Unfortunately, this doesn't work in the test runner.

Bug: 1114202
Change-Id: Ibfd60c9bb4742c03e459080be81bb7f14dc9c9a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343552
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: default avatarRohit Rao <rohitrao@chromium.org>
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#796187}
parent bd385752
...@@ -93,6 +93,16 @@ std::unique_ptr<net::test_server::HttpResponse> GetResponse( ...@@ -93,6 +93,16 @@ std::unique_ptr<net::test_server::HttpResponse> GetResponse(
// Tests that QLPreviewController is shown for sucessfully downloaded USDZ file. // Tests that QLPreviewController is shown for sucessfully downloaded USDZ file.
- (void)testDownloadUsdz { - (void)testDownloadUsdz {
#if defined(__IPHONE_14_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_14_0
// TODO(crbug.com/1114202): The XCUIElement queries in this test are broken on
// Xcode 12 beta 4 when running on the iOS 12 simulator. Disable until Xcode
// is fixed.
if (@available(iOS 13, *)) {
} else {
EARL_GREY_TEST_DISABLED(@"Test disabled on iOS12.");
}
#endif
[ChromeEarlGrey loadURL:self.testServer->GetURL("/")]; [ChromeEarlGrey loadURL:self.testServer->GetURL("/")];
[ChromeEarlGrey waitForWebStateContainingText:"Good"]; [ChromeEarlGrey waitForWebStateContainingText:"Good"];
[ChromeEarlGrey tapWebStateElementWithID:@"good"]; [ChromeEarlGrey tapWebStateElementWithID:@"good"];
...@@ -125,6 +135,16 @@ std::unique_ptr<net::test_server::HttpResponse> GetResponse( ...@@ -125,6 +135,16 @@ std::unique_ptr<net::test_server::HttpResponse> GetResponse(
} }
- (void)testDownloadUnauthorized { - (void)testDownloadUnauthorized {
#if defined(__IPHONE_14_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_14_0
// TODO(crbug.com/1114202): The XCUIElement queries in this test are broken on
// Xcode 12 beta 4 when running on the iOS 12 simulator. Disable until Xcode
// is fixed.
if (@available(iOS 13, *)) {
} else {
EARL_GREY_TEST_DISABLED(@"Test disabled on iOS12.");
}
#endif
[ChromeEarlGrey loadURL:self.testServer->GetURL("/")]; [ChromeEarlGrey loadURL:self.testServer->GetURL("/")];
[ChromeEarlGrey waitForWebStateContainingText:"Unauthorized"]; [ChromeEarlGrey waitForWebStateContainingText:"Unauthorized"];
[ChromeEarlGrey tapWebStateElementWithID:@"unauthorized"]; [ChromeEarlGrey tapWebStateElementWithID:@"unauthorized"];
...@@ -157,6 +177,16 @@ std::unique_ptr<net::test_server::HttpResponse> GetResponse( ...@@ -157,6 +177,16 @@ std::unique_ptr<net::test_server::HttpResponse> GetResponse(
} }
- (void)testDownloadForbidden { - (void)testDownloadForbidden {
#if defined(__IPHONE_14_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_14_0
// TODO(crbug.com/1114202): The XCUIElement queries in this test are broken on
// Xcode 12 beta 4 when running on the iOS 12 simulator. Disable until Xcode
// is fixed.
if (@available(iOS 13, *)) {
} else {
EARL_GREY_TEST_DISABLED(@"Test disabled on iOS12.");
}
#endif
[ChromeEarlGrey loadURL:self.testServer->GetURL("/")]; [ChromeEarlGrey loadURL:self.testServer->GetURL("/")];
[ChromeEarlGrey waitForWebStateContainingText:"Forbidden"]; [ChromeEarlGrey waitForWebStateContainingText:"Forbidden"];
[ChromeEarlGrey tapWebStateElementWithID:@"forbidden"]; [ChromeEarlGrey tapWebStateElementWithID:@"forbidden"];
...@@ -189,6 +219,16 @@ std::unique_ptr<net::test_server::HttpResponse> GetResponse( ...@@ -189,6 +219,16 @@ std::unique_ptr<net::test_server::HttpResponse> GetResponse(
} }
- (void)testDownloadChangingMimeType { - (void)testDownloadChangingMimeType {
#if defined(__IPHONE_14_0) && __IPHONE_OS_VERSION_MAX_ALLOWED >= __IPHONE_14_0
// TODO(crbug.com/1114202): The XCUIElement queries in this test are broken on
// Xcode 12 beta 4 when running on the iOS 12 simulator. Disable until Xcode
// is fixed.
if (@available(iOS 13, *)) {
} else {
EARL_GREY_TEST_DISABLED(@"Test disabled on iOS12.");
}
#endif
[ChromeEarlGrey loadURL:self.testServer->GetURL("/")]; [ChromeEarlGrey loadURL:self.testServer->GetURL("/")];
[ChromeEarlGrey waitForWebStateContainingText:"Changing Mime Type"]; [ChromeEarlGrey waitForWebStateContainingText:"Changing Mime Type"];
[ChromeEarlGrey tapWebStateElementWithID:@"changing-mime-type"]; [ChromeEarlGrey tapWebStateElementWithID:@"changing-mime-type"];
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment