PathVisited UMA random values fix

The pathvisited UMA was recording every typo as a different page, we only want to record valid pages, so now we check if it a valid settings page before recording.

Bug: 869847
Change-Id: I53a7834f9d8544d9bc6bbdb3e2cca9887b2fb49e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1819311Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Sean Harrison <harrisonsean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#703344}

chrome/browser/resources/settings/route.js

@@ -749,12 +749,13 @@ cr.define('settings', function() {
      * Initialize the route and query params from the URL.
      */
     initializeRouteFromUrl() {
-      this.recordMetrics(window.location.pathname);
-
       assert(!this.initializeRouteFromUrlCalled_);
       this.initializeRouteFromUrlCalled_ = true;
 
       const route = this.getRouteForPath(window.location.pathname);
+      if (route) {
+        this.recordMetrics(window.location.pathname);
+      }
       // Never allow direct navigation to ADVANCED.
       if (route && route != this.routes_.ADVANCED) {
         this.currentRoute = route;
@@ -773,6 +774,7 @@ cr.define('settings', function() {
       assert(!urlPath.startsWith('chrome://'));
       assert(!urlPath.startsWith('settings'));
       assert(urlPath.startsWith('/'));
+      assert(!urlPath.match(/\?/g));
       chrome.metricsPrivate.recordSparseHashable(
           'WebUI.Settings.PathVisited', urlPath);
     }