Commit 3424a65a authored by Jérôme Lebel's avatar Jérôme Lebel Committed by Commit Bot

[iOS] Fixing skip button in sign-in

Adding adding content edge insets for the skip button in the user
sign-in coordinator.
Updating the skip button title, to always be in upper case, to match
the old implementation (MDCButton seems to always have upper case
title).

Before:
https://drive.google.com/open?id=1a1worTgClUtfs3p3YUwp45vH3-DhCflJ
After:
https://drive.google.com/open?id=19MrZ6a-lP1LBUWonredKKY3zxM4SbsGQ

Bug: 971989
Change-Id: I0eddfc2d855413926e794af1713aedc916a82656
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130549
Auto-Submit: Jérôme Lebel <jlebel@chromium.org>
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: default avatarNohemi Fernandez <fernandex@chromium.org>
Cr-Commit-Position: refs/heads/master@{#755290}
parent 5886bd91
...@@ -280,12 +280,15 @@ enum AuthenticationButtonType { ...@@ -280,12 +280,15 @@ enum AuthenticationButtonType {
DCHECK(self.unifiedConsentViewController); DCHECK(self.unifiedConsentViewController);
self.skipSigninButton = [[UIButton alloc] init]; self.skipSigninButton = [[UIButton alloc] init];
[self addSubviewWithButton:self.skipSigninButton]; [self addSubviewWithButton:self.skipSigninButton];
[self.skipSigninButton setTitle:self.skipSigninButtonTitle [self.skipSigninButton setTitle:self.skipSigninButtonTitle.uppercaseString
forState:UIControlStateNormal]; forState:UIControlStateNormal];
[self setSkipSigninStylingWithButton:self.skipSigninButton]; [self setSkipSigninStylingWithButton:self.skipSigninButton];
[self.skipSigninButton addTarget:self [self.skipSigninButton addTarget:self
action:@selector(onSkipSigninButtonPressed:) action:@selector(onSkipSigninButtonPressed:)
forControlEvents:UIControlEventTouchUpInside]; forControlEvents:UIControlEventTouchUpInside];
self.skipSigninButton.contentEdgeInsets =
UIEdgeInsetsMake(kButtonTitleContentInset, kButtonTitleContentInset,
kButtonTitleContentInset, kButtonTitleContentInset);
} }
// Sets up button properties and adds it to view. // Sets up button properties and adds it to view.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment