Test new hypotheses in CloseAndLockAndDisturb
Modify BodyStreamBuffer::CloseAndLockAndDisturb to test new hypotheses about what is causing the crashes in this function. 1. Test whether IsContextDestroyed() is ever true by adding a CHECK if it is. 2. Test whether stream_ can be empty if stream_broken_ is false. Tests with a busy loop have indicated that this function is sometimes called with stream_broken_ set to true. This raises the question if failures still happen when it is false. This CL will cause it to CHECK if stream_broken_ is false and stream_ is empty. This CL causes intentional crashes and should not be left in the beta version as-is. BUG=882599 Change-Id: Id71b66c51fcab0e821a411a2a97866c992b3f36d Reviewed-on: https://chromium-review.googlesource.com/1245040Reviewed-by:Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#594618}
Showing
Please register or sign in to comment