Skip to content

GitLab

T
tangled
Commit 345ea069 authored by Kenneth Russell's avatar Kenneth Russell Committed by Commit Bot
Browse files
Options

Run ASAN/MSAN/TSAN gl_tests on physical hardware. 

We should add a better way to define mixins like these, but for the
time being, add exceptions to trigger these jobs on physical hardware.

Bug: 830659, 835072
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_asan_rel_ng;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng
Change-Id: I30c377d28e6c2ea1202d0d64f86de9665c0266ad
Reviewed-on: https://chromium-review.googlesource.com/1013127
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: default avatarNico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552253}
parent ca3a73ca
Hide whitespace changes
Inline Side-by-side
Showing with 177 additions and 6 deletions
gpu/command_buffer/tests/gl_oes_egl_image_unittest.cc
View file @ 345ea069
......@@ -43,6 +43,8 @@ class GpuOESEGLImageTest : public testing::Test,
};
#if defined(OS_LINUX)
// TODO(crbug.com/835072): re-enable this test on ASAN once bugs are fixed.
#if !defined(ADDRESS_SANITIZER)
#define SHADER(Src) #Src
......@@ -172,6 +174,7 @@ TEST_F(GpuOESEGLImageTest, EGLImageToTexture) {
glDeleteBuffers(1, &vbo);
glDeleteTextures(1, &texture_id);
}
#endif // !defined(ADDRESS_SANITIZER)
#endif // defined(OS_LINUX)
} // namespace
testing/buildbot/chromium.memory.json
View file @ 345ea069
......@@ -897,6 +897,26 @@
},
"test": "gfx_unittests"
},
{
"args": [
"--no-xvfb",
"--test-launcher-batch-limit=1",
"--test-launcher-print-test-stdio=always",
"--use-gpu-in-tests"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "10de:1cb3",
"os": "Ubuntu",
"pool": "Chrome-GPU"
}
]
},
"test": "gl_tests",
"use_xvfb": false
},
{
"args": [
"--test-launcher-batch-limit=1",
......@@ -1449,6 +1469,24 @@
},
"test": "gin_unittests"
},
{
"args": [
"--use-gpu-in-tests",
"--no-xvfb"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "10de:1cb3",
"os": "Ubuntu",
"pool": "Chrome-GPU"
}
]
},
"test": "gl_tests",
"use_xvfb": false
},
{
"args": [
"--use-gpu-in-tests",
......@@ -2800,6 +2838,24 @@
},
"test": "gin_unittests"
},
{
"args": [
"--use-gpu-in-tests",
"--no-xvfb"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "10de:1cb3",
"os": "Ubuntu",
"pool": "Chrome-GPU"
}
]
},
"test": "gl_tests",
"use_xvfb": false
},
{
"swarming": {
"can_use_on_swarming_builders": true
......@@ -3165,6 +3221,24 @@
},
"test": "gin_unittests"
},
{
"args": [
"--use-gpu-in-tests",
"--no-xvfb"
],
"swarming": {
"can_use_on_swarming_builders": true,
"dimension_sets": [
{
"gpu": "10de:1cb3",
"os": "Ubuntu",
"pool": "Chrome-GPU"
}
]
},
"test": "gl_tests",
"use_xvfb": false
},
{
"swarming": {
"can_use_on_swarming_builders": true
......
testing/buildbot/test_suite_exceptions.pyl
View file @ 345ea069
......@@ -1531,12 +1531,6 @@
# chromium.fyi
'Out of Process Profiling Linux',
'ThinLTO Linux ToT',
# chromium.memory
'Linux ASan LSan Tests (1)', # https://crbug.com/830659
'Linux CFI', # https://crbug.com/830659
'Linux MSan Tests', # https://crbug.com/830659
'Linux ChromiumOS MSan Tests', # https://crbug.com/830659
'Linux TSan Tests', # https://crbug.com/830659
],
'modifications': {
'KitKat Tablet Tester': {
......@@ -1549,6 +1543,106 @@
'hard_timeout': 120,
},
},
# chromium.memory
# https://crbug.com/830659
# TODO(kbr): figure out a better way to specify blocks of
# arguments like this for tests on multiple machines.
'Linux ASan LSan Tests (1)': {
'args': [
'--use-gpu-in-tests',
'--no-xvfb',
],
'swarming': {
'dimension_sets': [
{
'gpu': '10de:1cb3',
'os': 'Ubuntu',
'pool': 'Chrome-GPU',
},
],
},
'use_xvfb': False,
},
'Linux ASan LSan Tests (1)': {
'args': [
'--use-gpu-in-tests',
'--no-xvfb',
],
'swarming': {
'dimension_sets': [
{
'gpu': '10de:1cb3',
'os': 'Ubuntu',
'pool': 'Chrome-GPU',
},
],
},
'use_xvfb': False,
},
'Linux CFI': {
'args': [
'--use-gpu-in-tests',
'--no-xvfb',
],
'swarming': {
'dimension_sets': [
{
'gpu': '10de:1cb3',
'os': 'Ubuntu',
'pool': 'Chrome-GPU',
},
],
},
'use_xvfb': False,
},
'Linux MSan Tests': {
'args': [
'--use-gpu-in-tests',
'--no-xvfb',
],
'swarming': {
'dimension_sets': [
{
'gpu': '10de:1cb3',
'os': 'Ubuntu',
'pool': 'Chrome-GPU',
},
],
},
'use_xvfb': False,
},
'Linux ChromiumOS MSan Tests': {
'args': [
'--use-gpu-in-tests',
'--no-xvfb',
],
'swarming': {
'dimension_sets': [
{
'gpu': '10de:1cb3',
'os': 'Ubuntu',
'pool': 'Chrome-GPU',
},
],
},
'use_xvfb': False,
},
'Linux TSan Tests': {
'args': [
'--use-gpu-in-tests',
'--no-xvfb',
],
'swarming': {
'dimension_sets': [
{
'gpu': '10de:1cb3',
'os': 'Ubuntu',
'pool': 'Chrome-GPU',
},
],
},
'use_xvfb': False,
},
},
},
'gl_unittests': {
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment