Commit 346457f6 authored by David Bokan's avatar David Bokan Committed by Chromium LUCI CQ

Remove mouse wheel handler DCHECK

In wheel handling, we assume that if a wheel event is set to
non-blocking it must not be the first in the sequence so the previous
event disposition should be available in mouse_wheel_result_.

In https://crbug.com/1069760 that was found not to be the case. The fix
there was to revert to the previous behavior which checked for whether
that was true (the underlying cause wasn't found) but a DCHECK was left
in. This trips up builds that have DCHECKs enabled as in
https://crbug.com/1156940.

Bug: 1156940,1069760
Change-Id: Ia65b5a0c28c4214492ec0cd9072ff8e5467bfdd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580054Reviewed-by: default avatarXida Chen <xidachen@chromium.org>
Commit-Queue: David Bokan <bokan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835282}
parent f68d9827
...@@ -896,7 +896,6 @@ InputHandlerProxy::EventDisposition InputHandlerProxy::HandleMouseWheel( ...@@ -896,7 +896,6 @@ InputHandlerProxy::EventDisposition InputHandlerProxy::HandleMouseWheel(
DCHECK(wheel_event.phase != WebMouseWheelEvent::kPhaseNone || DCHECK(wheel_event.phase != WebMouseWheelEvent::kPhaseNone ||
wheel_event.momentum_phase != WebMouseWheelEvent::kPhaseNone); wheel_event.momentum_phase != WebMouseWheelEvent::kPhaseNone);
DCHECK(mouse_wheel_result_.has_value());
// TODO(bokan): This should never happen but after changing // TODO(bokan): This should never happen but after changing
// mouse_event_result_ to a base::Optional, crashes indicate that it does // mouse_event_result_ to a base::Optional, crashes indicate that it does
// so |if| maintains prior behavior. https://crbug.com/1069760. // so |if| maintains prior behavior. https://crbug.com/1069760.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment