Skip to content

GitLab

T
tangled
Commit 34a5e2e1 authored by rbpotter's avatar rbpotter Committed by Commit Bot
Browse files
Options

Web UI: Fix minify_polymer to work with bundler v4 

third_party/polymer/v1_0/minify_polymer.py was using --in-html and
--out-html arguments to Polymer bundler when minifying polymer. These
arguments are no longer valid in bundler v4, so the script was
broken by:
https://chromium-review.googlesource.com/c/chromium/src/+/1857568

Update the script to work with the new version of bundler.

Bug: 921285
Change-Id: I52f82ef3cfb36ec79c61e69aec7185098d19226c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1873372Reviewed-by: default avatarDemetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#708280}
parent 306ab1cb
Hide whitespace changes
Inline Side-by-side
Showing with 3 additions and 4 deletions
third_party/polymer/v1_0/components-chromium/polymer2/polymer.html
View file @ 34a5e2e1
...@@ -6,5 +6,4 @@ The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt ...@@ -6,5 +6,4 @@ The complete set of authors may be found at http://polymer.github.io/AUTHORS.txt
The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt The complete set of contributors may be found at http://polymer.github.io/CONTRIBUTORS.txt
Code distributed by Google as part of the polymer project is also Code distributed by Google as part of the polymer project is also
subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt subject to an additional IP rights grant found at http://polymer.github.io/PATENTS.txt
--><html><head></head><body><div hidden="" by-polymer-bundler=""></div> --><html><head></head><body><div hidden="" by-polymer-bundler=""></div><script src="polymer-extracted.js"></script></body></html>
<script src="polymer-extracted.js"></script></body></html> \ No newline at end of file
\ No newline at end of file
third_party/polymer/v1_0/minify_polymer.py
View file @ 34a5e2e1
...@@ -43,8 +43,8 @@ def main(): ...@@ -43,8 +43,8 @@ def main():
'--strip-comments', '--strip-comments',
'--inline-scripts', '--inline-scripts',
'--inline-css', '--inline-css',
'--in-html', os.path.join(tmp_dir, 'polymer.html'), '--out-file', os.path.join(tmp_out_dir, 'polymer.html'),
'--out-html', os.path.join(tmp_out_dir, 'polymer.html') os.path.join(tmp_dir, 'polymer.html'),
]) ])
# Extract the JS to a separate file named polymer-extracted.js. # Extract the JS to a separate file named polymer-extracted.js.
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment