Commit 34d5ab46 authored by Alexander Hendrich's avatar Alexander Hendrich Committed by Chromium LUCI CQ

Fix LoginScreenStorageCleaner

With our new handling of the pref that handles the force-installed
login screen extensions (https://crrev.com/c/2561847), the
LoginScreenStorageCleaner will be created before the policy is mapped
to its pref. This causes the LoginScreenStorageCleaner to incorrectly
clear all login screen storage entries since it believes that no
extensions are installed.

Simple fix is to remove the call to
ClearPersistentDataForUninstalledExtensions() in its constructor and
only apply this logic when the policy was applied.

Bug: 1157435
Change-Id: Ie8203204c3706e3ffb4b3c0816e2c31e0f9a3036
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2584023Reviewed-by: default avatarRoman Sorokin [CET] <rsorokin@chromium.org>
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#835641}
parent 66a455a1
......@@ -31,7 +31,6 @@ LoginScreenExtensionsStorageCleaner::LoginScreenExtensionsStorageCleaner() {
extensions::pref_names::kInstallForceList,
base::BindRepeating(&LoginScreenExtensionsStorageCleaner::OnPolicyUpdated,
base::Unretained(this)));
ClearPersistentDataForUninstalledExtensions();
}
LoginScreenExtensionsStorageCleaner::~LoginScreenExtensionsStorageCleaner() =
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment