Elements that are positioned should not be ignored for a11y.

This fixes a bug with absolutely positioned webviews in apps such as Hangouts. Note that AutomationApiTest.LocationInWebView fails without the change to AXLayoutObject.cpp. Bug: 801995 Change-Id: I1a3e8e66f3f64b7ec6f619076374438aad901d65 Reviewed-on: https://chromium-review.googlesource.com/894182Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#533239}

Elements that are positioned should not be ignored for a11y.
This fixes a bug with absolutely positioned webviews in apps such as Hangouts. Note that AutomationApiTest.LocationInWebView fails without the change to AXLayoutObject.cpp. Bug: 801995 Change-Id: I1a3e8e66f3f64b7ec6f619076374438aad901d65 Reviewed-on: https://chromium-review.googlesource.com/894182Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#533239}
34d90966 · Katie D · Commit Bot · 8442e044 · 34d90966 · 34d90966
Commit 34d90966 authored Jan 31, 2018 by Katie D Committed by Commit Bot Jan 31, 2018
10 changed files
--- a/chrome/test/data/extensions/api_test/automation/tests/webview/webview_frame.html
+++ b/chrome/test/data/extensions/api_test/automation/tests/webview/webview_frame.html
+<!DOCTYPE html>
 <html>
  <head>
    <title>Frame with WebView</title>

--- a/content/test/data/accessibility/html/modal-dialog-opened-expected-android.txt
+++ b/content/test/data/accessibility/html/modal-dialog-opened-expected-android.txt
 android.webkit.WebView focusable scrollable
++android.view.View
 ++android.app.Dialog role_description='dialog'
 ++++android.view.View name='The dialog subtree should be the only text content in the accessibility tree. '
-++++android.view.View role_description='link' clickable focusable focused link name='Link inside the dialog.'
\ No newline at end of file
++++android.view.View role_description='link' clickable focusable focused link name='Link inside the dialog.'
--- a/content/test/data/accessibility/html/modal-dialog-opened-expected-blink.txt
+++ b/content/test/data/accessibility/html/modal-dialog-opened-expected-blink.txt
 rootWebArea
++genericContainer
 ++dialog
 ++++staticText name='The dialog subtree should be the only text content in the accessibility tree. '
 ++++++inlineTextBox name='The dialog subtree should be the only text content in the accessibility tree. '
 ++++link name='Link inside the dialog.'
 ++++++staticText name='Link inside the dialog.'
-++++++++inlineTextBox name='Link inside the dialog.'
\ No newline at end of file
++++++++inlineTextBox name='Link inside the dialog.'
--- a/content/test/data/accessibility/html/modal-dialog-opened-expected-mac.txt
+++ b/content/test/data/accessibility/html/modal-dialog-opened-expected-mac.txt
 AXWebArea
++AXGroup
 ++AXGroup AXSubrole=AXApplicationDialog
 ++++AXStaticText AXValue='The dialog subtree should be the only text content in the accessibility tree. '
 ++++AXLink AXTitle='Link inside the dialog.'

--- a/content/test/data/accessibility/html/modal-dialog-opened-expected-win.txt
+++ b/content/test/data/accessibility/html/modal-dialog-opened-expected-win.txt
 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
++IA2_ROLE_SECTION
 ++ROLE_SYSTEM_DIALOG IA2_STATE_MODAL
 ++++ROLE_SYSTEM_STATICTEXT name='The dialog subtree should be the only text content in the accessibility tree. '
 ++++ROLE_SYSTEM_LINK name='Link inside the dialog.' FOCUSABLE
-++++++ROLE_SYSTEM_STATICTEXT name='Link inside the dialog.'
\ No newline at end of file
++++++ROLE_SYSTEM_STATICTEXT name='Link inside the dialog.'
--- a/content/test/data/accessibility/html/modal-dialog-stack-expected-android.txt
+++ b/content/test/data/accessibility/html/modal-dialog-stack-expected-android.txt
 android.webkit.WebView focusable focused scrollable
++android.view.View
 ++android.app.Dialog role_description='dialog'
 ++++android.view.View name='This is the now active dialog. Of course it should be in the tree. '
-++++android.widget.Button role_description='button' clickable focusable name='This is in the active dialog and should be in the tree.'
\ No newline at end of file
++++android.widget.Button role_description='button' clickable focusable name='This is in the active dialog and should be in the tree.'
--- a/content/test/data/accessibility/html/modal-dialog-stack-expected-blink.txt
+++ b/content/test/data/accessibility/html/modal-dialog-stack-expected-blink.txt
 rootWebArea
++genericContainer
 ++dialog
 ++++staticText name='This is the now active dialog. Of course it should be in the tree. '
 ++++++inlineTextBox name='This is the now active dialog. Of course it should be in the tree. '
-++++button name='This is in the active dialog and should be in the tree.'
\ No newline at end of file
++++button name='This is in the active dialog and should be in the tree.'
--- a/content/test/data/accessibility/html/modal-dialog-stack-expected-mac.txt
+++ b/content/test/data/accessibility/html/modal-dialog-stack-expected-mac.txt
 AXWebArea
++AXGroup
 ++AXGroup AXSubrole=AXApplicationDialog
 ++++AXStaticText AXValue='This is the now active dialog. Of course it should be in the tree. '
 ++++AXButton AXTitle='This is in the active dialog and should be in the tree.'
--- a/content/test/data/accessibility/html/modal-dialog-stack-expected-win.txt
+++ b/content/test/data/accessibility/html/modal-dialog-stack-expected-win.txt
 ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE
++IA2_ROLE_SECTION
 ++ROLE_SYSTEM_DIALOG IA2_STATE_MODAL
 ++++ROLE_SYSTEM_STATICTEXT name='This is the now active dialog. Of course it should be in the tree. '
-++++ROLE_SYSTEM_PUSHBUTTON name='This is in the active dialog and should be in the tree.' FOCUSABLE
\ No newline at end of file
++++ROLE_SYSTEM_PUSHBUTTON name='This is in the active dialog and should be in the tree.' FOCUSABLE
--- a/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp
@@ -719,8 +719,12 @@ bool AXLayoutObject::ComputeAccessibilityIsIgnored(
  if (IsGenericFocusableElement() && node->hasChildren())
    return false;

+  // Positioned elements and scrollable containers are important for
+  // determining bounding boxes.
  if (IsScrollableContainer())
    return false;
+  if (layout_object_->IsPositioned())
+    return false;

  // Ignore layout objects that are block flows with inline children. These
  // are usually dummy layout objects that pad out the tree, but there are