[WPT] Fix muted errors flag around setTimeout/setInterval

According to the spec
https://html.spec.whatwg.org/C/#timer-initialisation-steps
setTimeout()/setInterval() don't inherit
initiating script's muted errors flag,
which matches with Chromium/Firefox/Safari.

This CL fixes WPT tests to match with the spec/impl, i.e.
to expect errors from setTimeout()/setInterval()
from cross-origin scripts not to be muted.

Bug: 1111134
Change-Id: I3b4d0a5450ccee8fb04113846c9e9773d476cfe7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2485416Reviewed-by: Domenic Denicola <domenic@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#822054}

third_party/blink/renderer/bindings/core/v8/scheduled_action.cc

@@ -132,10 +132,8 @@ void ScheduledAction::Execute(ExecutionContext* context) {
     return;
   }
 
-  // We're using |SanitizeScriptErrors::kDoNotSanitize| to keep the existing
-  // behavior, but this causes failures on
-  // wpt/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-setTimeout.html
-  // and friends.
+  // We use |SanitizeScriptErrors::kDoNotSanitize| because muted errors flag is
+  // not set in https://html.spec.whatwg.org/C/#timer-initialisation-steps
   DVLOG(1) << "ScheduledAction::execute " << this << ": executing from source";
   if (LocalDOMWindow* window = DynamicTo<LocalDOMWindow>(context)) {
     window->GetScriptController().ExecuteScriptAndReturnValue(

third_party/blink/web_tests/android/ChromiumWPTExpectations

@@ -2720,8 +2720,6 @@ crbug.com/1050754 external/wpt/html/webappapis/scripting/events/event-handler-al
 crbug.com/1050754 external/wpt/html/webappapis/scripting/events/event-handler-attributes-body-window.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/events/event-handler-attributes-frameset-window.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/events/event-handler-attributes-windowless-body.html [ Failure ]
-crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-setInterval.html [ Failure ]
-crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-setTimeout.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/compile-error-in-setInterval.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/compile-error-same-origin-with-hash.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-failure.https.any.html [ Failure ]
@@ -2729,8 +2727,6 @@ crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/inte
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-success.any.sharedworker.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-success.any.worker.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-incumbent.html [ Failure ]
-crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-setInterval.html [ Failure ]
-crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-setTimeout.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-in-setInterval.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-in-setTimeout.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-same-origin-with-hash.html [ Failure ]

third_party/blink/web_tests/android/WeblayerWPTExpectations

@@ -2624,8 +2624,6 @@ crbug.com/1050754 external/wpt/html/webappapis/scripting/events/event-handler-al
 crbug.com/1050754 external/wpt/html/webappapis/scripting/events/event-handler-attributes-body-window.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/events/event-handler-attributes-frameset-window.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/events/event-handler-attributes-windowless-body.html [ Failure ]
-crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-setInterval.html [ Failure ]
-crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-setTimeout.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/compile-error-in-setInterval.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/compile-error-same-origin-with-hash.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-failure.https.any.html [ Failure ]
@@ -2633,8 +2631,6 @@ crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/inte
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-success.any.sharedworker.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-success.any.worker.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-incumbent.html [ Failure ]
-crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-setInterval.html [ Failure ]
-crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-setTimeout.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-in-setInterval.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-in-setTimeout.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-same-origin-with-hash.html [ Failure ]

third_party/blink/web_tests/android/WebviewWPTExpectations

@@ -2835,8 +2835,6 @@ crbug.com/1050754 external/wpt/html/webappapis/scripting/events/event-handler-al
 crbug.com/1050754 external/wpt/html/webappapis/scripting/events/event-handler-attributes-body-window.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/events/event-handler-attributes-frameset-window.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/events/event-handler-attributes-windowless-body.html [ Failure ]
-crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-setInterval.html [ Failure ]
-crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-setTimeout.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/compile-error-in-setInterval.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/compile-error-same-origin-with-hash.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-agent-formalism/requires-failure.https.any.html [ Failure ]
@@ -2846,8 +2844,6 @@ crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/inte
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry-different-function-realm.html [ Timeout ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-entry.html [ Timeout ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/integration-with-the-javascript-job-queue/promise-job-incumbent.html [ Failure ]
-crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-setInterval.html [ Failure ]
-crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-setTimeout.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-in-setInterval.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-in-setTimeout.html [ Failure ]
 crbug.com/1050754 external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-same-origin-with-hash.html [ Failure ]

third_party/blink/web_tests/external/wpt/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-setInterval-expected.txt

-This is a testharness.js-based test.
-FAIL window.onerror - compile error in cross-origin setInterval assert_equals: first arg expected "Script error." but got "Uncaught SyntaxError: Unexpected end of input"
-FAIL window.onerror - compile error in cross-origin setInterval (column) assert_equals: fourth arg expected 0 but got 2
-Harness: the test ran to completion.
-

third_party/blink/web_tests/external/wpt/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-setInterval.html

@@ -10,22 +10,13 @@
   <script>
     setup({allow_uncaught_exception:true});
     var t = async_test();
-    var t_col = async_test(document.title+' (column)');
     var ran = false;
-    var col_value;
     var interval;
-    window.onerror = t.step_func(function(a, b, c, d){
+    window.addEventListener('error', t.step_func(e => {
         clearInterval(interval);
         ran = true;
-        col_value = d;
-        assert_equals(a, 'Script error.', 'first arg');
-        assert_equals(b, '', 'second arg');
-        assert_equals(c, 0, 'third arg');
-    });
-    function col_check() {
-        assert_equals(col_value, 0, 'fourth arg');
-        t_col.done();
-    }
+        assert_equals(e.error.constructor, SyntaxError);
+    }));
     var script = document.createElement('script');
     script.src = location.href.replace('://', '://www1.').replace(/\/[^\/]+$/, '/support/syntax-error-in-setInterval.js');
     document.body.appendChild(script);

third_party/blink/web_tests/external/wpt/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-setTimeout-expected.txt

-This is a testharness.js-based test.
-FAIL window.onerror - compile error in cross-origin setTimeout assert_equals: first arg expected "Script error." but got "Uncaught SyntaxError: Unexpected end of input"
-FAIL window.onerror - compile error in cross-origin setTimeout (column) assert_equals: fourth arg expected 0 but got 2
-Harness: the test ran to completion.
-

third_party/blink/web_tests/external/wpt/html/webappapis/scripting/processing-model-2/compile-error-cross-origin-setTimeout.html

@@ -10,20 +10,11 @@
   <script>
     setup({allow_uncaught_exception:true});
     var t = async_test();
-    var t_col = async_test(document.title+' (column)');
     var ran = false;
-    var col_value;
-    window.onerror = t.step_func(function(a, b, c, d){
+    window.addEventListener('error', t.step_func(e => {
         ran = true;
-        col_value = d;
-        assert_equals(a, 'Script error.', 'first arg');
-        assert_equals(b, '', 'second arg');
-        assert_equals(c, 0, 'third arg');
-    });
-    function col_check() {
-        assert_equals(col_value, 0, 'fourth arg');
-        t_col.done();
-    }
+        assert_equals(e.error.constructor, SyntaxError);
+    }));
     var script = document.createElement('script');
     script.src = location.href.replace('://', '://www1.').replace(/\/[^\/]+$/, '/support/syntax-error-in-setTimeout.js');
     document.body.appendChild(script);

third_party/blink/web_tests/external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-setInterval-expected.txt

-This is a testharness.js-based test.
-FAIL window.onerror - runtime error in cross-origin setInterval assert_equals: first arg expected "Script error." but got "Uncaught ReferenceError: undefined_variable is not defined"
-FAIL window.onerror - runtime error in cross-origin setInterval (column) assert_equals: fourth arg expected 0 but got 1
-Harness: the test ran to completion.
-

third_party/blink/web_tests/external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-setInterval.html

@@ -10,22 +10,13 @@
   <script>
     setup({allow_uncaught_exception:true});
     var t = async_test();
-    var t_col = async_test(document.title+' (column)');
     var ran = false;
-    var col_value;
     var interval;
-    window.onerror = t.step_func(function(a, b, c, d){
+    window.addEventListener('error', t.step_func(e => {
         clearInterval(interval);
         ran = true;
-        col_value = d;
-        assert_equals(a, 'Script error.', 'first arg');
-        assert_equals(b, '', 'second arg');
-        assert_equals(c, 0, 'third arg');
-    });
-    function col_check() {
-        assert_equals(col_value, 0, 'fourth arg');
-        t_col.done();
-    }
+        assert_equals(e.error.constructor, ReferenceError);
+    }));
     var script = document.createElement('script');
     script.src = location.href.replace('://', '://www1.').replace(/\/[^\/]+$/, '/support/undefined-variable-in-setInterval.js');
     document.body.appendChild(script);

third_party/blink/web_tests/external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-setTimeout-expected.txt

-This is a testharness.js-based test.
-FAIL window.onerror - runtime error in cross-origin setTimeout assert_equals: first arg expected "Script error." but got "Uncaught ReferenceError: undefined_variable is not defined"
-FAIL window.onerror - runtime error in cross-origin setTimeout (column) assert_equals: fourth arg expected 0 but got 1
-Harness: the test ran to completion.
-

third_party/blink/web_tests/external/wpt/html/webappapis/scripting/processing-model-2/runtime-error-cross-origin-setTimeout.html

@@ -10,20 +10,11 @@
   <script>
     setup({allow_uncaught_exception:true});
     var t = async_test();
-    var t_col = async_test(document.title+' (column)');
     var ran = false;
-    var col_value;
-    window.onerror = t.step_func(function(a, b, c, d){
+    window.addEventListener('error', t.step_func(e => {
         ran = true;
-        col_value = d;
-        assert_equals(a, 'Script error.', 'first arg');
-        assert_equals(b, '', 'second arg');
-        assert_equals(c, 0, 'third arg');
-    });
-    function col_check() {
-        assert_equals(col_value, 0, 'fourth arg');
-        t_col.done();
-    }
+        assert_equals(e.error.constructor, ReferenceError);
+    }));
     var script = document.createElement('script');
     script.src = location.href.replace('://', '://www1.').replace(/\/[^\/]+$/, '/support/undefined-variable-in-setTimeout.js');
     document.body.appendChild(script);

third_party/blink/web_tests/external/wpt/html/webappapis/scripting/processing-model-2/support/syntax-error-in-setInterval.js

@@ -5,5 +5,4 @@ step_timeout(function(){
         assert_true(ran, 'ran');
         t.done();
     });
-    t_col.step(col_check);
 }, 20);
\ No newline at end of file

third_party/blink/web_tests/external/wpt/html/webappapis/scripting/processing-model-2/support/syntax-error-in-setTimeout.js

@@ -4,5 +4,4 @@ setTimeout(function(){
         assert_true(ran, 'ran');
         t.done();
     });
-    t_col.step(col_check);
 }, 20);

third_party/blink/web_tests/external/wpt/html/webappapis/scripting/processing-model-2/support/undefined-variable-in-setInterval.js

@@ -5,5 +5,4 @@ step_timeout(function(){
         assert_true(ran, 'ran');
         t.done();
     });
-    t_col.step(col_check);
 }, 20);
\ No newline at end of file

third_party/blink/web_tests/external/wpt/html/webappapis/scripting/processing-model-2/support/undefined-variable-in-setTimeout.js

@@ -4,5 +4,4 @@ setTimeout(function(){
         assert_true(ran, 'ran');
         t.done();
     });
-    t_col.step(col_check);
 }, 20);