Commit 34f3b1cd authored by Devlin Cronin's avatar Devlin Cronin Committed by Commit Bot

[Extensions] Restrict deprecated methods to MV2

There's a collection of extension API methods that have been deprecated
for some time. Restrict these to manifest version 2, so that they are
unused in manifest version 3.

Bug: 987838
Change-Id: I5ec33a29ceb1eade40e1b97f3692164b581715fb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2441022Reviewed-by: default avatarKaran Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#814859}
parent 7e15f6b1
...@@ -190,6 +190,12 @@ ...@@ -190,6 +190,12 @@
"dependencies": ["permission:certificateProvider"], "dependencies": ["permission:certificateProvider"],
"contexts": ["blessed_extension"] "contexts": ["blessed_extension"]
}, },
"certificateProvider.onCertificatesRequested": {
"max_manifest_version": 2
},
"certificateProvider.onSignDigestRequested": {
"max_manifest_version": 2
},
"certificateProviderInternal": { "certificateProviderInternal": {
"internal": true, "internal": true,
"dependencies": ["permission:certificateProvider"], "dependencies": ["permission:certificateProvider"],
...@@ -390,10 +396,12 @@ ...@@ -390,10 +396,12 @@
}, },
"extension.getExtensionTabs": { "extension.getExtensionTabs": {
"contexts": ["blessed_extension"], "contexts": ["blessed_extension"],
"disallow_for_service_workers": true "disallow_for_service_workers": true,
"max_manifest_version": 2
}, },
"extension.getURL": { "extension.getURL": {
"contexts": ["blessed_extension", "unblessed_extension", "content_script"] "contexts": ["blessed_extension", "unblessed_extension", "content_script"],
"max_manifest_version": 2
}, },
"extension.getViews": [ "extension.getViews": [
{ {
...@@ -417,13 +425,19 @@ ...@@ -417,13 +425,19 @@
"contexts": ["blessed_extension", "unblessed_extension", "content_script"] "contexts": ["blessed_extension", "unblessed_extension", "content_script"]
}, },
"extension.lastError": { "extension.lastError": {
"contexts": ["blessed_extension", "unblessed_extension", "content_script"] "contexts": ["blessed_extension", "unblessed_extension", "content_script"],
"max_manifest_version": 2
}, },
"extension.onRequest": { "extension.onRequest": {
"contexts": ["blessed_extension", "unblessed_extension", "content_script"] "contexts": ["blessed_extension", "unblessed_extension", "content_script"],
"max_manifest_version": 2
},
"extension.onRequestExternal": {
"max_manifest_version": 2
}, },
"extension.sendRequest": { "extension.sendRequest": {
"contexts": ["blessed_extension", "unblessed_extension", "content_script"] "contexts": ["blessed_extension", "unblessed_extension", "content_script"],
"max_manifest_version": 2
}, },
"extensionOptionsInternal": { "extensionOptionsInternal": {
"internal": true, "internal": true,
...@@ -738,7 +752,8 @@ ...@@ -738,7 +752,8 @@
"tabs": [{ "tabs": [{
"channel": "stable", "channel": "stable",
"extension_types": ["extension", "legacy_packaged_app"], "extension_types": ["extension", "legacy_packaged_app"],
"contexts": ["blessed_extension"] "contexts": ["blessed_extension"],
"default_parent": true
}, { }, {
"channel": "stable", "channel": "stable",
"contexts": ["webui"], "contexts": ["webui"],
...@@ -754,6 +769,24 @@ ...@@ -754,6 +769,24 @@
], ],
"platforms": ["chromeos"] "platforms": ["chromeos"]
}], }],
"tabs.getAllInWindow": {
"max_manifest_version": 2
},
"tabs.getSelected": {
"max_manifest_version": 2
},
"tabs.onActiveChanged": {
"max_manifest_version": 2
},
"tabs.onHighlightChanged": {
"max_manifest_version": 2
},
"tabs.onSelectionChanged": {
"max_manifest_version": 2
},
"tabs.sendRequest": {
"max_manifest_version": 2
},
// chrome.terminalPrivate allowed for nassh extensions, // chrome.terminalPrivate allowed for nassh extensions,
// chrome-untrusted://crosh, and chrome-untrusted://terminal. // chrome-untrusted://crosh, and chrome-untrusted://terminal.
"terminalPrivate": [{ "terminalPrivate": [{
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment