Skip to content

GitLab

T
tangled
Commit 34fbecfe authored by David Jean's avatar David Jean Committed by Commit Bot
Browse files
Options

[ios] Add metrics for credit card and address manual fallback 

Bug: 905654,905656
Change-Id: I331e96047e3c88e812247e7dab6a2181894f760b
Reviewed-on: https://chromium-review.googlesource.com/c/1341517
Commit-Queue: David Jean <djean@chromium.org>
Reviewed-by: default avatarMark Pearson <mpearson@chromium.org>
Reviewed-by: default avatarJavier Ernesto Flores Robles <javierrobles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611626}
parent 71d688ab
Hide whitespace changes
Inline Side-by-side
Showing with 156 additions and 0 deletions
ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.mm
View file @ 34fbecfe
......@@ -4,6 +4,7 @@
#import "ios/chrome/browser/ui/autofill/manual_fill/manual_fill_address_cell.h"
#include "base/metrics/user_metrics.h"
#import "ios/chrome/browser/ui/autofill/manual_fill/manual_fill_cell_utils.h"
#import "ios/chrome/browser/ui/autofill/manual_fill/manual_fill_content_delegate.h"
#import "ios/chrome/browser/ui/autofill/manual_fill/uicolor_manualfill.h"
......@@ -487,6 +488,35 @@ static const CGFloat SideMargins = 16;
}
- (void)userDidTapAddressInfo:(UIButton*)sender {
const char* metricsAction = nullptr;
if (sender == self.firstNameButton) {
metricsAction = "ManualFallback_Profiles_SelectFirstName";
} else if (sender == self.middleNameButton) {
metricsAction = "ManualFallback_Profiles_SelectMiddleName";
} else if (sender == self.lastNameButton) {
metricsAction = "ManualFallback_Profiles_SelectLastName";
} else if (sender == self.companyButton) {
metricsAction = "ManualFallback_Profiles_Company";
} else if (sender == self.line1Button) {
metricsAction = "ManualFallback_Profiles_Address1";
} else if (sender == self.line2Button) {
metricsAction = "ManualFallback_Profiles_Address2";
} else if (sender == self.zipButton) {
metricsAction = "ManualFallback_Profiles_Zip";
} else if (sender == self.cityButton) {
metricsAction = "ManualFallback_Profiles_City";
} else if (sender == self.stateButton) {
metricsAction = "ManualFallback_Profiles_State";
} else if (sender == self.countryButton) {
metricsAction = "ManualFallback_Profiles_Country";
} else if (sender == self.phoneNumberButton) {
metricsAction = "ManualFallback_Profiles_PhoneNumber";
} else if (sender == self.emailAddressButton) {
metricsAction = "ManualFallback_Profiles_EmailAddress";
}
DCHECK(metricsAction);
base::RecordAction(base::UserMetricsAction(metricsAction));
[self.delegate userDidPickContent:sender.titleLabel.text
isPasswordField:NO
requiresHTTPS:NO];
......
ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.mm
View file @ 34fbecfe
......@@ -4,6 +4,7 @@
#import "ios/chrome/browser/ui/autofill/manual_fill/manual_fill_card_cell.h"
#include "base/metrics/user_metrics.h"
#include "base/strings/sys_string_conversions.h"
#include "base/strings/utf_string_conversions.h"
#import "ios/chrome/browser/ui/autofill/manual_fill/card_list_delegate.h"
......@@ -227,6 +228,8 @@ static const CGFloat SideMargins = 16;
}
- (void)userDidTapCardNumber:(UIButton*)sender {
base::RecordAction(
base::UserMetricsAction("ManualFallback_CreditCard_SelectCardNumber"));
NSString* number = self.card.number;
if (!number.length) {
[self.navigationDelegate requestFullCreditCard:self.card];
......@@ -238,6 +241,17 @@ static const CGFloat SideMargins = 16;
}
- (void)userDidTapCardInfo:(UIButton*)sender {
const char* metricsAction = nullptr;
if (sender == self.cardholderButton) {
metricsAction = "ManualFallback_CreditCard_SelectCardholderName";
} else if (sender == self.expirationMonthButton) {
metricsAction = "ManualFallback_CreditCard_SelectExpirationMonth";
} else if (sender == self.expirationYearButton) {
metricsAction = "ManualFallback_CreditCard_SelectExpirationYear";
}
DCHECK(metricsAction);
base::RecordAction(base::UserMetricsAction(metricsAction));
[self.contentDelegate userDidPickContent:sender.titleLabel.text
isPasswordField:NO
requiresHTTPS:NO];
......
tools/metrics/actions/actions.xml
View file @ 34fbecfe
......@@ -10144,6 +10144,34 @@ should be able to be added at any place in this file.
</description>
</action>
<action name="ManualFallback_CreditCard_SelectCardholderName">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on a cardholder name in the Credit Card Fallback view.
</description>
</action>
<action name="ManualFallback_CreditCard_SelectCardNumber">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on a credit card number in the Credit Card Fallback view.
</description>
</action>
<action name="ManualFallback_CreditCard_SelectExpirationMonth">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on an expiration month in the Credit Card Fallback view.
</description>
</action>
<action name="ManualFallback_CreditCard_SelectExpirationYear">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on an expiration year in the Credit Card Fallback view.
</description>
</action>
<action name="ManualFallback_OpenCreditCard">
<owner>javierrobles@chromium.org</owner>
<description>The user opened Credit Card Manual Fallback view.</description>
......@@ -10189,6 +10217,48 @@ should be able to be added at any place in this file.
</description>
</action>
<action name="ManualFallback_Profiles_Address1">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on line 1 in the Address Manual Fallback view.
</description>
</action>
<action name="ManualFallback_Profiles_Address2">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on line 2 in the Address Manual Fallback view.
</description>
</action>
<action name="ManualFallback_Profiles_City">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on a city in the Address Manual Fallback view.
</description>
</action>
<action name="ManualFallback_Profiles_Company">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on a company name in the Address Manual Fallback view.
</description>
</action>
<action name="ManualFallback_Profiles_Country">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on a country in the Address Manual Fallback view.
</description>
</action>
<action name="ManualFallback_Profiles_EmailAddress">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on an email address in the Address Manual Fallback view.
</description>
</action>
<action name="ManualFallback_Profiles_OpenManageProfiles">
<owner>javierrobles@chromium.org</owner>
<description>
......@@ -10197,6 +10267,48 @@ should be able to be added at any place in this file.
</description>
</action>
<action name="ManualFallback_Profiles_PhoneNumber">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on a phone number in the Address Manual Fallback view.
</description>
</action>
<action name="ManualFallback_Profiles_SelectFirstName">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on a first name in the Address Manual Fallback view.
</description>
</action>
<action name="ManualFallback_Profiles_SelectLastName">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on a last name in the Address Manual Fallback view.
</description>
</action>
<action name="ManualFallback_Profiles_SelectMiddleName">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on a middle name in the Address Manual Fallback view.
</description>
</action>
<action name="ManualFallback_Profiles_State">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on a state / province in the Address Manual Fallback view.
</description>
</action>
<action name="ManualFallback_Profiles_Zip">
<owner>javierrobles@chromium.org</owner>
<description>
The user tapped on a zip code in the Address Manual Fallback view.
</description>
</action>
<action name="MaxButton_Clk_ExitFS">
<owner>Please list the metric's owners. Add more owner tags as needed.</owner>
<description>Please enter the description of this user action.</description>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment