Commit 34ffe97b authored by Jonathan Ross's avatar Jonathan Ross Committed by Commit Bot

Revert "OS Settings: Update to use preprocess_grit"

This reverts commit f454440c.

Reason for revert: chromeos compile failed with a dirty tree. Ninja pointing to OS Settings as likely culprit:

"ninja explain: output gen/chrome/browser/resources/settings/chromeos/preprocess_v3/chromeos/os_settings.html of phony edge with no inputs doesn't exist"

https://ci.chromium.org/p/chromium/builders/ci/chromeos-amd64-generic-rel/47276?

Original change's description:
> OS Settings: Update to use preprocess_grit
>
> OS settings is the last remaining user of unpack_pak. By migrating it to
> use preprocess_grit, unpack_pak can be deleted, preventing any new UIs
> from adding more usage. All UIs should instead use preprocess_grit
> (and, eventually, autogenerate grd files with generate_grd).
>
> Planning to update OS settings to autogenerate grd files in a followup.
>
> Bug: 1132403
> Change-Id: I5378836543befb224a82e58b0211bafba9aead64
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487885
> Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
> Reviewed-by: dpapad <dpapad@chromium.org>
> Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#819485}

TBR=khorimoto@chromium.org,dpapad@chromium.org,rbpotter@chromium.org

Change-Id: Ibaed7c55cc29a22bde6272d6a29f2ee201e79111
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1132403
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490511Reviewed-by: default avatarJonathan Ross <jonross@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#819524}
parent 546a02b0
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment