Have BrowserAppMenuButton use toolbar treatment

AppMenuButton overrides ToolbarButton::OnBoundsChanged because it's not
always hosted inside the toolbar. Color and text treatment for
ToolbarButton assumes that it is. Since BrowserAppMenuButton is hosted
in the toolbar area, and can make use of text / color it needs to use
ToolbarButton::OnBoundsChanged too.

Bug: None
Change-Id: I20282139da46e4160e00e23b29ea61a5ff32ef30
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1829279
Commit-Queue: Peter Boström <pbos@chromium.org>
Commit-Queue: Taylor Bergquist <tbergquist@chromium.org>
Auto-Submit: Peter Boström <pbos@chromium.org>
Reviewed-by: Taylor Bergquist <tbergquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700810}

chrome/browser/ui/views/toolbar/browser_app_menu_button.cc

@@ -299,6 +299,13 @@ void BrowserAppMenuButton::OnTouchUiChanged() {
   PreferredSizeChanged();
 }
 
+void BrowserAppMenuButton::OnBoundsChanged(const gfx::Rect& previous_bounds) {
+  // AppMenuButton overrides parts of the ToolbarButton behavior.
+  // BrowserAppMenuButton is hosted on the toolbar so we need to make sure that
+  // ToolbarButton backgrounds etc. are properly updated.
+  ToolbarButton::OnBoundsChanged(previous_bounds);
+}
+
 const char* BrowserAppMenuButton::GetClassName() const {
   return "BrowserAppMenuButton";
 }

chrome/browser/ui/views/toolbar/browser_app_menu_button.h

@@ -73,6 +73,7 @@ class BrowserAppMenuButton : public AppMenuButton,
   base::Optional<SkColor> GetPromoHighlightColor() const;
 
   // AppMenuButton:
+  void OnBoundsChanged(const gfx::Rect& previous_bounds) override;
   const char* GetClassName() const override;
   bool GetDropFormats(int* formats,
                       std::set<ui::ClipboardFormatType>* format_types) override;