Commit 350f3eb9 authored by Pâris Meuleman's avatar Pâris Meuleman Committed by Commit Bot

Revert "devtools>Security: Fix display for trusted non-https pages (chrome://)"

This reverts commit a1dbeba4.

Reason for revert: The root cause was fixed in https://crbug.com/976192#c4

Original change's description:
> devtools>Security: Fix display for trusted non-https pages (chrome://)
> 
> This CL is a quick-fix for the issue detailed in the attached bug.
> Devtools' Security tab does not handle properly resources from secure,
> non-https, origins, this leads to an attempt to display a certificate
> that does not exist and a crash (CHECK). The issue stems in Blink, where
> the resources' responses (|ResourceLoader|) are not equal to documents'
> responses (|DocumentLoader). This response is then handled differently
> by the security tab. The solution proposed here addresses the problem on
> Devtools UI side by checking the content of the Response's
> SecurityDetails.
> 
> Bug: 973744
> Change-Id: I8714f4d30f8a8d42cb54e42347dfcf5ca0c3a9c8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658470
> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
> Commit-Queue: Alexei Filippov <alph@chromium.org>
> Reviewed-by: Alexei Filippov <alph@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#668903}

TBR=alph@chromium.org,pmeuleman@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 973744
Change-Id: I3f97c03606aae872b397ec381985e062c98af921
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676634
Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org>
Reviewed-by: default avatarTsuyoshi Horo <horo@chromium.org>
Reviewed-by: default avatarAlexei Filippov <alph@chromium.org>
Commit-Queue: Pâris Meuleman <pmeuleman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#673278}
parent e68db965
......@@ -809,7 +809,7 @@ Security.SecurityOriginView = class extends UI.VBox {
UI.ARIAUtils.markAsLink(originNetworkButton);
originNetworkDiv.appendChild(originNetworkButton);
if (originState.securityDetails && originState.securityDetails.protocol.length > 0) {
if (originState.securityDetails) {
const connectionSection = this.element.createChild('div', 'origin-view-section');
const connectionDiv = connectionSection.createChild('div', 'origin-view-section-title');
connectionDiv.textContent = ls`Connection`;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment