[Mfill Android] Show all suggestions when focused with talkback

When talkback is turned on, there would be a deferred focus event. This
triggered hiding autofill suggestions which is wrong for the keyboard
accessory.

This CL ensures that the keyboard accessory relies fully on its own
logic to decide when to hide autofill suggestions.

Bug: 969202
Change-Id: I88d2c1456990d4e4ed8e292d37b7c8eb10d29797
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790889Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#694809}

components/autofill/content/renderer/autofill_agent.cc

@@ -203,7 +203,7 @@ void AutofillAgent::DidChangeScrollOffset() {
         ->PostTask(FROM_HERE,
                    base::BindOnce(&AutofillAgent::DidChangeScrollOffsetImpl,
                                   weak_ptr_factory_.GetWeakPtr(), element_));
-  } else if (!IsKeyboardAccessoryEnabled()) {
+  } else {
     HidePopup();
   }
 }
@@ -224,8 +224,7 @@ void AutofillAgent::DidChangeScrollOffsetImpl(
   }
 
   // Ignore subsequent scroll offset changes.
-  if (!IsKeyboardAccessoryEnabled())
-    HidePopup();
+  HidePopup();
 }
 
 void AutofillAgent::FocusedElementChanged(const WebElement& element) {
@@ -639,8 +638,7 @@ void AutofillAgent::ShowSuggestions(const WebFormControlElement& element,
   // criteria are not met.
   WebString value = element.EditingValue();
   if (value.length() > kMaxDataLength ||
-      (!IsKeyboardAccessoryEnabled() && !options.autofill_on_empty_values &&
-       value.IsEmpty()) ||
+      (!options.autofill_on_empty_values && value.IsEmpty()) ||
       (options.requires_caret_at_end &&
        (element.SelectionStart() != element.SelectionEnd() ||
         element.SelectionEnd() != static_cast<int>(value.length())))) {
@@ -840,6 +838,10 @@ void AutofillAgent::HidePopup() {
   is_popup_possibly_visible_ = false;
   is_generation_popup_possibly_visible_ = false;
 
+  // The keyboard accessory has a separate, more complex hiding logic.
+  if (IsKeyboardAccessoryEnabled())
+    return;
+
   GetAutofillDriver()->HidePopup();
 }