overview: Update unsnappable indicators for display rotation

Whether an overview window is eligible for split view depends upon work
area dimensions in relation to the window's minimum size. Therefore it
can change with display orientation. So the unsnappable indicator shall
be updated when the display is rotated.

Test: ash_unittests All/SplitViewOverviewSessionTest.*
Test: ash_unittests All/SplitViewOverviewSessionInClamshellTest.*
Fixed: 1027806
Change-Id: I666c9fb16c0b64931d538bc9d8b80f3af7392da8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1949193
Commit-Queue: Avery Musbach <amusbach@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#721591}

ash/wm/overview/overview_grid.cc

@@ -913,6 +913,7 @@ void OverviewGrid::OnDisplayMetricsChanged() {
   if (split_view_drag_indicators_)
     split_view_drag_indicators_->OnDisplayBoundsChanged();
 
+  UpdateCannotSnapWarningVisibility();
   // In case of split view mode, the grid bounds and item positions will be
   // updated in |OnSplitViewDividerPositionChanged|.
   if (SplitViewController::Get(root_window_)->InSplitViewMode())
@@ -955,11 +956,11 @@ void OverviewGrid::OnSplitViewStateChanged(
     return;
   }
 
-  // Adjust the grid bounds and update the cannot snap warnings.
+  // Update the cannot snap warnings and adjust the grid bounds.
+  UpdateCannotSnapWarningVisibility();
   SetBoundsAndUpdatePositions(
       GetGridBoundsInScreen(root_window_, /*divider_changed=*/false),
       /*ignored_items=*/{}, /*animate=*/false);
-  UpdateCannotSnapWarningVisibility();
 
   // Activate the overview focus window, to match the behavior of entering
   // overview mode in the beginning.

ash/wm/overview/overview_session_unittest.cc

@@ -4649,6 +4649,42 @@ TEST_P(SplitViewOverviewSessionTest,
   EXPECT_EQ(1.f, unsnappable_layer->opacity());
 }
 
+// Verify that an item's unsnappable indicator is updated for display rotation.
+TEST_P(SplitViewOverviewSessionTest,
+       OverviewUnsnappableIndicatorVisibilityAfterDisplayRotation) {
+  UpdateDisplay("800x800");
+  std::unique_ptr<aura::Window> snapped_window = CreateTestWindow();
+  // Because of its minimum size, |overview_window| is snappable in horizontal
+  // split view but not in vertical split view.
+  std::unique_ptr<aura::Window> overview_window(
+      CreateWindowWithMinimumSize(gfx::Rect(400, 600), gfx::Size(300, 500)));
+  ToggleOverview();
+  ASSERT_TRUE(overview_controller()->InOverviewSession());
+  split_view_controller()->SnapWindow(snapped_window.get(),
+                                      SplitViewController::LEFT);
+  ASSERT_TRUE(split_view_controller()->InSplitViewMode());
+  OverviewItem* overview_item = GetOverviewItemForWindow(overview_window.get());
+  // Note: |cannot_snap_label_view_| and its parent will be created on demand.
+  EXPECT_FALSE(overview_item->cannot_snap_widget_for_testing());
+
+  // Rotate to primary portrait orientation. The unsnappable indicator appears.
+  display::test::DisplayManagerTestApi(Shell::Get()->display_manager())
+      .SetFirstDisplayAsInternalDisplay();
+  ScreenOrientationControllerTestApi test_api(
+      Shell::Get()->screen_orientation_controller());
+  test_api.SetDisplayRotation(display::Display::ROTATE_270,
+                              display::Display::RotationSource::ACTIVE);
+  ASSERT_TRUE(overview_item->cannot_snap_widget_for_testing());
+  ui::Layer* unsnappable_layer =
+      overview_item->cannot_snap_widget_for_testing()->GetLayer();
+  EXPECT_EQ(1.f, unsnappable_layer->opacity());
+
+  // Rotate to primary landscape orientation. The unsnappable indicator hides.
+  test_api.SetDisplayRotation(display::Display::ROTATE_0,
+                              display::Display::RotationSource::ACTIVE);
+  EXPECT_EQ(0.f, unsnappable_layer->opacity());
+}
+
 // Test that when splitview mode and overview mode are both active at the same
 // time, dragging divider behaviors are correct.
 TEST_P(SplitViewOverviewSessionTest, DragDividerToExitTest) {
@@ -5656,6 +5692,42 @@ TEST_P(SplitViewOverviewSessionInClamshellTest, DisplayOrientationChangeTest) {
   test_many_orientation_changes("off-center divider");
 }
 
+// Verify that an item's unsnappable indicator is updated for display rotation.
+TEST_P(SplitViewOverviewSessionInClamshellTest,
+       OverviewUnsnappableIndicatorVisibilityAfterDisplayRotation) {
+  UpdateDisplay("900x600");
+  std::unique_ptr<aura::Window> snapped_window = CreateTestWindow();
+  // Because of its minimum size, |overview_window| is snappable in clamshell
+  // split view with landscape display orientation but not with portrait display
+  // orientation.
+  std::unique_ptr<aura::Window> overview_window(
+      CreateWindowWithMinimumSize(gfx::Rect(400, 400), gfx::Size(400, 0)));
+  ToggleOverview();
+  ASSERT_TRUE(overview_controller()->InOverviewSession());
+  split_view_controller()->SnapWindow(snapped_window.get(),
+                                      SplitViewController::LEFT);
+  ASSERT_TRUE(split_view_controller()->InSplitViewMode());
+  OverviewItem* overview_item = GetOverviewItemForWindow(overview_window.get());
+  // Note: |cannot_snap_label_view_| and its parent will be created on demand.
+  EXPECT_FALSE(overview_item->cannot_snap_widget_for_testing());
+
+  // Rotate to primary portrait orientation. The unsnappable indicator appears.
+  display::DisplayManager* display_manager = Shell::Get()->display_manager();
+  const int64_t display_id =
+      display::Screen::GetScreen()->GetPrimaryDisplay().id();
+  display_manager->SetDisplayRotation(display_id, display::Display::ROTATE_270,
+                                      display::Display::RotationSource::ACTIVE);
+  ASSERT_TRUE(overview_item->cannot_snap_widget_for_testing());
+  ui::Layer* unsnappable_layer =
+      overview_item->cannot_snap_widget_for_testing()->GetLayer();
+  EXPECT_EQ(1.f, unsnappable_layer->opacity());
+
+  // Rotate to primary landscape orientation. The unsnappable indicator hides.
+  display_manager->SetDisplayRotation(display_id, display::Display::ROTATE_0,
+                                      display::Display::RotationSource::ACTIVE);
+  EXPECT_EQ(0.f, unsnappable_layer->opacity());
+}
+
 using SplitViewOverviewSessionInClamshellTestMultiDisplayOnly =
     SplitViewOverviewSessionInClamshellTest;